[glib] Always report metadata on the path, not symlink target
- From: Alexander Larsson <alexl src gnome org>
- To: svn-commits-list gnome org
- Cc:
- Subject: [glib] Always report metadata on the path, not symlink target
- Date: Mon, 28 Sep 2009 14:08:21 +0000 (UTC)
commit 6f1ce483eb136159f42b7dde3aa4466ba3e874c1
Author: Alexander Larsson <alexl redhat com>
Date: Mon Sep 28 15:55:44 2009 +0200
Always report metadata on the path, not symlink target
Metadata are really part of the pathname, not the target file
(as they are stored by pathname, and for many metadata like icon position
etc make not sense using the target data). So, even if nofollow
is not specified we should not follow links for metadata.
Ideally this should be implemented in the metadata extension in gvfs,
but the extension API does not allow this, so we do it in gio.
See https://bugzilla.gnome.org/show_bug.cgi?id=593809
gio/glocalfileinfo.c | 11 +----------
1 files changed, 1 insertions(+), 10 deletions(-)
---
diff --git a/gio/glocalfileinfo.c b/gio/glocalfileinfo.c
index 7076aac..0a063e9 100644
--- a/gio/glocalfileinfo.c
+++ b/gio/glocalfileinfo.c
@@ -1709,17 +1709,8 @@ _g_local_file_info_get (const char *basename,
class = G_VFS_GET_CLASS (vfs);
if (class->local_file_add_info)
{
- const char *extra_target;
-
- extra_target = path;
- if (!(flags & G_FILE_QUERY_INFO_NOFOLLOW_SYMLINKS) &&
- is_symlink &&
- !symlink_broken &&
- symlink_target != NULL)
- extra_target = symlink_target;
-
class->local_file_add_info (vfs,
- extra_target,
+ path,
statbuf.st_dev,
attribute_matcher,
info,
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]