[network-manager-pptp] properties: really fix saving MPPE settings (lp:371402)



commit 0c39c37fe4a395529bb7025027f60931152fd6ac
Author: Dan Williams <dcbw redhat com>
Date:   Tue Oct 13 12:03:09 2009 -0700

    properties: really fix saving MPPE settings (lp:371402)
    
    Found by David Jordan and others
    
    Fixed for some, but broken for others by commit
    22d8b96a294673431a94c4976870cfbd2746d469.  REQUIRE_MPPE will pass
    --require-mppe to pppd, which will let pppd accept both 128 and 64
    bit connections.  Some servers have policy that will reject clients
    that accept lower-security encryption, so setting REQUIRE_MPPE
    only when neither 128 or 64 are set is the right fix.

 properties/advanced-dialog.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
---
diff --git a/properties/advanced-dialog.c b/properties/advanced-dialog.c
index 0e1368b..dfd43df 100644
--- a/properties/advanced-dialog.c
+++ b/properties/advanced-dialog.c
@@ -385,11 +385,10 @@ advanced_dialog_new_hash_from_dialog (GtkWidget *dialog, GError **error)
 			g_hash_table_insert (hash, g_strdup (NM_PPTP_KEY_REQUIRE_MPPE_40), g_strdup ("yes"));
 			break;
 		default:
+			g_hash_table_insert (hash, g_strdup (NM_PPTP_KEY_REQUIRE_MPPE), g_strdup ("yes"));
 			break;
 		}
 
-		g_hash_table_insert (hash, g_strdup (NM_PPTP_KEY_REQUIRE_MPPE), g_strdup ("yes"));
-
 		widget = glade_xml_get_widget (xml, "ppp_allow_stateful_mppe");
 		if (gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (widget)))
 			g_hash_table_insert (hash, g_strdup (NM_PPTP_KEY_MPPE_STATEFUL), g_strdup ("yes"));



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]