[empathy] Removed leak with g_string_free, added comment for 0xFFFC



commit ff1393e672b5e10fd7589a25349188ac6e9bbc73
Author: Gabriel Millaire <millaire gabriel gmail com>
Date:   Tue Oct 6 10:24:52 2009 +0200

    Removed leak with g_string_free, added comment for 0xFFFC

 libempathy-gtk/empathy-chat-text-view.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
---
diff --git a/libempathy-gtk/empathy-chat-text-view.c b/libempathy-gtk/empathy-chat-text-view.c
index 5b0a356..aacc847 100644
--- a/libempathy-gtk/empathy-chat-text-view.c
+++ b/libempathy-gtk/empathy-chat-text-view.c
@@ -1180,6 +1180,8 @@ chat_text_view_copy_clipboard (EmpathyChatView *view)
 
 	for (iter = start; !gtk_text_iter_equal (&iter, &end); gtk_text_iter_forward_char (&iter)) {
 		c = gtk_text_iter_get_char (&iter);
+		/* 0xFFFC is the 'object replacement' unicode character,
+		 * it indicates the presence of a pixbuf or a widget. */
 		if (c == 0xFFFC) {
 			ignore_newlines = FALSE;
 			if ((pixbuf = gtk_text_iter_get_pixbuf (&iter))) {
@@ -1210,7 +1212,8 @@ chat_text_view_copy_clipboard (EmpathyChatView *view)
 		}
 	}
 
-	gtk_clipboard_set_text (clipboard, g_string_free (str, FALSE), str->len);
+	gtk_clipboard_set_text (clipboard, str->str, str->len);
+	g_string_free (str, TRUE)
 }
 
 static void



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]