[rhythmbox] player-gst: fix crash on pipeline shutdown failure (bug #586985)



commit dea10f4abd5e5b7b44d0322711423a993543d434
Author: Jonathan Matthew <jonathan d14n org>
Date:   Fri Jun 26 10:14:43 2009 +1000

    player-gst: fix crash on pipeline shutdown failure (bug #586985)

 backends/gstreamer/rb-player-gst.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/backends/gstreamer/rb-player-gst.c b/backends/gstreamer/rb-player-gst.c
index fb94f1d..9e56d57 100644
--- a/backends/gstreamer/rb-player-gst.c
+++ b/backends/gstreamer/rb-player-gst.c
@@ -621,7 +621,7 @@ set_state_and_wait (RBPlayerGst *player, GstState target, GError **error)
 		}
 	}
 
-	if (result == FALSE && *error == NULL) {
+	if (result == FALSE && error != NULL && *error == NULL) {
 		g_set_error (error,
 			     RB_PLAYER_ERROR,
 			     RB_PLAYER_ERROR_GENERAL,



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]