GNOME.org
 

[gstreamermm] Completed some TODO's.

commit 6e1b64a93ad85bee9ae26b7f0db712dfa7c54cc7
Author: José Alburquerque <jaalburqu svn gnome org>
Date:   Wed Jul 29 22:44:45 2009 -0400

    Completed some TODO's.

 ChangeLog                      |   11 +++++++++++
 gstreamer/gstreamermm.h        |   12 ++++++------
 gstreamer/src/colorbalance.hg  |    2 +-
 gstreamer/src/message.ccg      |    6 ------
 gstreamer/src/message.hg       |    6 +-----
 gstreamer/src/mixer.hg         |    2 +-
 gstreamer/src/plugin.ccg       |    3 ---
 gstreamer/src/plugin.hg        |    3 ---
 gstreamer/src/propertyprobe.hg |    3 ++-
 9 files changed, 22 insertions(+), 26 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index f67062b..336bf70 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,16 @@
 2009-07-29  José Alburquerque  <jaalburqu svn gnome org>
 
+	* gstreamer/gstreamermm.h:
+	* gstreamer/src/colorbalance.hg:
+	* gstreamer/src/message.ccg:
+	* gstreamer/src/message.hg:
+	* gstreamer/src/mixer.hg:
+	* gstreamer/src/plugin.ccg:
+	* gstreamer/src/plugin.hg:
+	* gstreamer/src/propertyprobe.hg: Completed some TODO's.
+
+2009-07-29  José Alburquerque  <jaalburqu svn gnome org>
+
 	* gstreamer/src/gst_docs.xml:
 	* gstreamer/src/gst_enums.defs:
 	* gstreamer/src/gst_signals.defs:
diff --git a/gstreamer/gstreamermm.h b/gstreamer/gstreamermm.h
index fa6f8fc..82fbe3c 100644
--- a/gstreamer/gstreamermm.h
+++ b/gstreamer/gstreamermm.h
@@ -99,7 +99,7 @@
 #include <gstreamermm/cdparanoiasrc.h>
 #include <gstreamermm/clockoverlay.h>
 #include <gstreamermm/decodebin.h>
-//TODO: #include <gstreamermm/decodebin2.h>
+#include <gstreamermm/decodebin2.h>
 #include <gstreamermm/ffmpegcolorspace.h>
 #include <gstreamermm/gdpdepay.h>
 #include <gstreamermm/gdppay.h>
@@ -109,22 +109,22 @@
 #include <gstreamermm/giostreamsrc.h>
 //TODO (Add plug-in first): #include <gstreamermm/gnomevfssink.h>
 //TODO (Add plug-in first): #include <gstreamermm/gnomevfssrc.h>
-//TODO (Add plug-in first): #include <gstreamermm/multifdsink.h>
+#include <gstreamermm/multifdsink.h>
 #include <gstreamermm/oggdemux.h>
 #include <gstreamermm/oggmux.h>
-//TODO (Add plug-in first): #include <gstreamermm/playbin.h>
+#include <gstreamermm/playbin.h>
 #include <gstreamermm/playbin2.h>
 #include <gstreamermm/tcpclientsrc.h>
 #include <gstreamermm/tcpclientsink.h>
 #include <gstreamermm/tcpserversrc.h>
-//TODO (Add plug-in first): #include <gstreamermm/tcpserversink.h>
+#include <gstreamermm/tcpserversink.h>
 #include <gstreamermm/textoverlay.h>
 #include <gstreamermm/textrender.h>
 #include <gstreamermm/theoradec.h>
 #include <gstreamermm/theoraenc.h>
-//TODO (Add plug-in first): #include <gstreamermm/theoraparse.h>
+#include <gstreamermm/theoraparse.h>
 #include <gstreamermm/timeoverlay.h>
-//TODO (Add plug-in first): #include <gstreamermm/uridecodebin.h>
+#include <gstreamermm/uridecodebin.h>
 #include <gstreamermm/videorate.h>
 #include <gstreamermm/videoscale.h>
 #include <gstreamermm/videotestsrc.h>
diff --git a/gstreamer/src/colorbalance.hg b/gstreamer/src/colorbalance.hg
index 8664653..fd04bc2 100644
--- a/gstreamer/src/colorbalance.hg
+++ b/gstreamer/src/colorbalance.hg
@@ -46,7 +46,7 @@ public:
   _WRAP_METHOD(int get_value(const Glib::RefPtr<const ColorBalanceChannel>& channel) const, gst_color_balance_get_value)
   _WRAP_METHOD(void set_value(const Glib::RefPtr<ColorBalanceChannel>& channel, int value), gst_color_balance_set_value)
   _WRAP_METHOD(void value_changed(const Glib::RefPtr<ColorBalanceChannel>& channel, int value), gst_color_balance_value_changed)
-  //TODO after 0.10.24: _WRAP_METHOD(Gst::ColorBalanceType get_balance_type() const, gst_color_balance_get_balance_type)
+  _WRAP_METHOD(Gst::ColorBalanceType get_balance_type() const, gst_color_balance_get_balance_type)
 
 #m4 _CONVERSION(`GstColorBalanceChannel*', `const Glib::RefPtr<ColorBalanceChannel>&', `Glib::wrap($3, true)')
   /** Fired when the value of the indicated channel has changed.
diff --git a/gstreamer/src/message.ccg b/gstreamer/src/message.ccg
index 4d7e3a5..727e133 100644
--- a/gstreamer/src/message.ccg
+++ b/gstreamer/src/message.ccg
@@ -672,8 +672,6 @@ Gst::State MessageRequestState::parse() const
   return (Gst::State)(gst_state);
 }
 
-//TODO: Include (by removing #if/#endif) when GStreamer 0.10.24 is released:
-#if 0
 MessageStreamStatus::MessageStreamStatus(GstMessage* castitem)
 : Message(castitem)
 {}
@@ -728,7 +726,6 @@ Glib::RefPtr<Gst::Element> MessageStreamStatus::parse_owner() const
     &gst_element);
   return Glib::wrap(gst_element, true);
 }
-#endif
 
 Glib::RefPtr<Gst::Message> Message::wrap(GstMessage* message, bool take_copy)
 {
@@ -804,12 +801,9 @@ Glib::RefPtr<Gst::Message> Message::wrap(GstMessage* message, bool take_copy)
       case GST_MESSAGE_REQUEST_STATE:
         result = Glib::RefPtr<Gst::Message>( new Gst::MessageRequestState(message) );
         break;
-      //TODO: Include when GStreamer 0.10.24 is released:
-      /*
       case GST_MESSAGE_STREAM_STATUS:
         result = Glib::RefPtr<Gst::Message>( new Gst::MessageStreamStatus(message) );
         break;
-      */
       case GST_MESSAGE_UNKNOWN:
       case GST_MESSAGE_ANY:
         result = Gst::wrap(message, false);
diff --git a/gstreamer/src/message.hg b/gstreamer/src/message.hg
index 21d8b8d..3295950 100644
--- a/gstreamer/src/message.hg
+++ b/gstreamer/src/message.hg
@@ -31,8 +31,7 @@ namespace Gst
 _WRAP_ENUM(MessageType, GstMessageType)
 _WRAP_ENUM(StructureChangeType, GstStructureChangeType)
 
-//TODO: Include when GStreamer 0.10.24 is released:
-//_WRAP_ENUM(StreamStatusType, GstStreamStatusType)
+_WRAP_ENUM(StreamStatusType, GstStreamStatusType)
 
 namespace Enums
 {
@@ -1006,8 +1005,6 @@ public:
   _IGNORE(gst_message_parse_request_state)
 };
 
-//TODO: Include (by removing #if/#endif) when GStreamer 0.10.24 is released:
-#if 0
 /** A stream status message.
  * See create() for more details.
  */
@@ -1080,6 +1077,5 @@ public:
    */
   Glib::RefPtr<Gst::Element> parse_owner() const;
 };
-#endif
 
 } //namespace Gst
diff --git a/gstreamer/src/mixer.hg b/gstreamer/src/mixer.hg
index 1e630fe..ef328e9 100644
--- a/gstreamer/src/mixer.hg
+++ b/gstreamer/src/mixer.hg
@@ -72,7 +72,7 @@ public:
   _WRAP_METHOD(Glib::ustring get_option(const Glib::RefPtr<const Gst::MixerOptions>& opts) const, gst_mixer_get_option)
   _WRAP_METHOD(void mixer_changed(), gst_mixer_mixer_changed)
   _WRAP_METHOD(Gst::MixerFlags get_mixer_flags() const, gst_mixer_get_mixer_flags)
-  //TODO after 0.10.24: _WRAP_METHOD(Gst::MixerType get_mixer_type() const, gst_mixer_get_mixer_type)
+  _WRAP_METHOD(Gst::MixerType get_mixer_type() const, gst_mixer_get_mixer_type)
   _WRAP_METHOD(static Gst::MixerMessageType get_message_type(const Glib::RefPtr<Gst::Message>& message), gst_mixer_message_get_type)
 
   // Signals were deprecated before we could wrap them (see header file).
diff --git a/gstreamer/src/plugin.ccg b/gstreamer/src/plugin.ccg
index 05a5a46..1062b3a 100644
--- a/gstreamer/src/plugin.ccg
+++ b/gstreamer/src/plugin.ccg
@@ -45,8 +45,6 @@ gboolean Plugin_Init_gstreamermm_callback(GstPlugin* plugin, void* data)
 namespace Gst
 {
 
-//TODO: Include if bug #545787 is accepted; remove if not.
-/*
 bool Plugin::register_static(int major_version, int minor_version,
     const Glib::ustring& name, const Glib::ustring& description,
     const SlotInit& init_slot, const Glib::ustring& version,
@@ -60,6 +58,5 @@ bool Plugin::register_static(int major_version, int minor_version,
     &Plugin_Init_gstreamermm_callback, version.c_str(), license.c_str(),
     source.c_str(), package.c_str(), origin.c_str(), slot_copy);
 }
-*/
 
 } //namespace Gst
diff --git a/gstreamer/src/plugin.hg b/gstreamer/src/plugin.hg
index e0b53f8..585420e 100644
--- a/gstreamer/src/plugin.hg
+++ b/gstreamer/src/plugin.hg
@@ -104,14 +104,11 @@ public:
   // care of freeing.
   _IGNORE(gst_plugin_list_free)
 
-//TODO: Include if bug #545787 is accepted; remove if not.
-/*
   bool register_static(int major_version, int minor_version,
     const Glib::ustring& name, const Glib::ustring& description,
     const SlotInit& init_slot, const Glib::ustring& version,
     const Glib::ustring& license, const Glib::ustring& source,
     const Glib::ustring& package, const Glib::ustring& origin);
-*/
 
   //gst_plugin_name_filter is a C API convenience function which tells if a
   //plugin has a given name so ignore it.
diff --git a/gstreamer/src/propertyprobe.hg b/gstreamer/src/propertyprobe.hg
index 6842cca..f9e72f8 100644
--- a/gstreamer/src/propertyprobe.hg
+++ b/gstreamer/src/propertyprobe.hg
@@ -38,7 +38,8 @@ class PropertyProbe : public Glib::Interface
   _CLASS_INTERFACE(PropertyProbe, GstPropertyProbe, GST_PROPERTY_PROBE, GstPropertyProbeInterface)
 
 public:
-  //TODO: Use something other than const GList* as return:
+  //TODO: Use something other than const GList* as return (A Glib::ListHandle<>
+  //is not used because it's hard to know how to place GParamSpec* in one):
   _WRAP_METHOD(const GList* get_properties() const, gst_property_probe_get_properties)
 
   _WRAP_METHOD(const GParamSpec* get_property(const Glib::ustring& name) const, gst_property_probe_get_property)
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]