[glom] Really save field changes again.
- From: Murray Cumming <murrayc src gnome org>
- To: svn-commits-list gnome org
- Subject: [glom] Really save field changes again.
- Date: Fri, 10 Jul 2009 15:26:28 +0000 (UTC)
commit bdee5d8dbdbe8d6bcd0e3923ee8b08f65f096ceb
Author: Murray Cumming <murrayc murrayc com>
Date: Fri Jul 10 17:06:24 2009 +0200
Really save field changes again.
* glom/libglom/document/document_glom.cc: set_table_fields():
Avoid the broken attempt at optimization, so that field changes are always
saved, for instance when changing them via the Field Definition dialog.
Ubuntu Launchpad bug
https://bugs.launchpad.net/ubuntu/+source/glom/+bug/394507
(elmergato)
ChangeLog | 11 +++++++++++
glom/libglom/document/document.cc | 2 +-
2 files changed, 12 insertions(+), 1 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 09a3f52..edf7234 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,16 @@
2009-07-10 Murray Cumming <murrayc murrayc com>
+ Really save field changes again.
+
+ * glom/libglom/document/document_glom.cc: set_table_fields():
+ Avoid the broken attempt at optimization, so that field changes are always
+ saved, for instance when changing them via the Field Definition dialog.
+ Ubuntu Launchpad bug
+ https://bugs.launchpad.net/ubuntu/+source/glom/+bug/394507
+ (elmergato)
+
+2009-07-10 Murray Cumming <murrayc murrayc com>
+
* glom/dialog_import_csv.cc: advance_field(): Do not skip characters after
the ".
diff --git a/glom/libglom/document/document.cc b/glom/libglom/document/document.cc
index 686b6f9..e7073cd 100644
--- a/glom/libglom/document/document.cc
+++ b/glom/libglom/document/document.cc
@@ -852,7 +852,7 @@ void Document::set_table_fields(const Glib::ustring& table_name, const type_vec_
}
DocumentTableInfo& info = get_table_info_with_add(table_name);
- const bool will_change = (info.m_fields != vecFields); //TODO: Does this do a deep comparison?
+ const bool will_change = true; //This won't work because we didn't clone the fields before changing them: (info.m_fields != vecFields); //TODO: Does this do a deep comparison?
info.m_fields = vecFields;
set_modified(will_change);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]