[libgsf] xml: send errors to stderr, not stdout.



commit faf3e584e945bb0299e7acf346d20ac1712ab5a6
Author: Morten Welinder <terra gnome org>
Date:   Thu Aug 20 11:34:55 2009 -0400

    xml: send errors to stderr, not stdout.

 ChangeLog        |    5 +++++
 NEWS             |    2 ++
 gsf/gsf-libxml.c |    6 +++---
 3 files changed, 10 insertions(+), 3 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 0c6fbbe..ebab7bb 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2009-08-20  Morten Welinder  <terra gnome org>
+
+	* gsf/gsf-libxml.c (gsf_xml_in_start_element): Complain to stderr,
+	not stdout.  Fixes #592471.
+
 2009-06-20  Morten Welinder  <terra gnome org>
 
 	* configure.in: Post-release-bump.
diff --git a/NEWS b/NEWS
index 1589af7..88d3ef6 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,7 @@
 libgsf 1.14.16
 
+Morten:
+	* Fix problem with errors to stdout.  [#592471]
 
 --------------------------------------------------------------------------
 libgsf 1.14.15
diff --git a/gsf/gsf-libxml.c b/gsf/gsf-libxml.c
index 2c90818..64a828f 100644
--- a/gsf/gsf-libxml.c
+++ b/gsf/gsf-libxml.c
@@ -738,7 +738,7 @@ gsf_xml_in_start_element (GsfXMLInInternal *state, xmlChar const *name, xmlChar
 	if (state->unknown_depth++ > 0)
 		return;
 
-	g_print ("Unexpected element '%s' in state : \n\t", name);
+	g_printerr ("Unexpected element '%s' in state : \n\t", name);
 	ptr = state->pub.node_stack = g_slist_reverse (state->pub.node_stack);
 	if (ptr != NULL)	/* skip toplevel catch all */
 		ptr = ptr->next;
@@ -746,11 +746,11 @@ gsf_xml_in_start_element (GsfXMLInInternal *state, xmlChar const *name, xmlChar
 		node = ptr->data;
 		if (node != NULL) {
 /* FIXME FIXME FIXME if we really want this do we also want namespaces ? */
-			g_print ("%s -> ", node_name (&node->pub));
+			g_printerr ("%s -> ", node_name (&node->pub));
 		}
 	}
 	if (state->pub.node != NULL) {
-		g_print ("%s\n", node_name (state->pub.node));
+		g_printerr ("%s\n", node_name (state->pub.node));
 	}
 	state->pub.node_stack = g_slist_reverse (state->pub.node_stack);
 }



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]