[totem] Bug 591400 – Wrong exit code on failure
- From: Bastien Nocera <hadess src gnome org>
- To: svn-commits-list gnome org
- Cc:
- Subject: [totem] Bug 591400 – Wrong exit code on failure
- Date: Tue, 11 Aug 2009 08:11:33 +0000 (UTC)
commit f280da70f3955deef3dd3e34c15accf3ceac8962
Author: Bastien Nocera <hadess hadess net>
Date: Tue Aug 11 09:04:48 2009 +0100
Bug 591400 â?? Wrong exit code on failure
Only push got-metadata signal on error when we're in metadata mode,
it's useless to start checking for metadata when we can't open
the file.
src/backend/bacon-video-widget-gst-0.10.c | 14 ++++++++------
1 files changed, 8 insertions(+), 6 deletions(-)
---
diff --git a/src/backend/bacon-video-widget-gst-0.10.c b/src/backend/bacon-video-widget-gst-0.10.c
index 37a74cc..95a84db 100644
--- a/src/backend/bacon-video-widget-gst-0.10.c
+++ b/src/backend/bacon-video-widget-gst-0.10.c
@@ -3264,13 +3264,15 @@ bacon_video_widget_open (BaconVideoWidget * bvw,
ret = poll_for_state_change_full (bvw, bvw->priv->play,
GST_STATE_PAUSED, &err_msg, -1);
- bvw_process_pending_tag_messages (bvw);
- bacon_video_widget_get_stream_length (bvw);
- GST_DEBUG ("stream length = %u", bvw->priv->stream_length);
+ if (bvw->priv->use_type == BVW_USE_TYPE_METADATA) {
+ bvw_process_pending_tag_messages (bvw);
+ bacon_video_widget_get_stream_length (bvw);
+ GST_DEBUG ("stream length = %u", bvw->priv->stream_length);
- /* even in case of an error (e.g. no decoders installed) we might still
- * have useful metadata (like codec types, duration, etc.) */
- g_signal_emit (bvw, bvw_signals[SIGNAL_GOT_METADATA], 0, NULL);
+ /* even in case of an error (e.g. no decoders installed) we might still
+ * have useful metadata (like codec types, duration, etc.) */
+ g_signal_emit (bvw, bvw_signals[SIGNAL_GOT_METADATA], 0, NULL);
+ }
}
if (ret) {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]