gnumeric r16552 - in branches/gnumeric-1-8: . src

[mortenw svn gnome org]

Author: mortenw
Date: Sun May  4 13:57:11 2008
New Revision: 16552
URL: http://svn.gnome.org/viewvc/gnumeric?rev=16552&view=rev

Log:
2008-05-04  Morten Welinder  <terra gnome org>

	* src/wbc-gtk.c (cb_notebook_switch_page): When selecting a range
	for a dialog, do sheet changes fully.  Fixes #529309.



Modified:
   branches/gnumeric-1-8/ChangeLog
   branches/gnumeric-1-8/NEWS
   branches/gnumeric-1-8/src/wbc-gtk.c

Modified: branches/gnumeric-1-8/NEWS
==============================================================================
--- branches/gnumeric-1-8/NEWS	(original)
+++ branches/gnumeric-1-8/NEWS	Sun May  4 13:57:11 2008
@@ -24,6 +24,7 @@
 	* Implement F9 for evaluating a selected subexpression.
 	* Fix problem loading Quattro Pro files.  [#530183]
 	* Fix right/center text for Quattro Pro files.
+	* Fix problem with sheet changes during range selection.  [#529309]
 
 --------------------------------------------------------------------------
 Gnumeric 1.8.2

Modified: branches/gnumeric-1-8/src/wbc-gtk.c
==============================================================================
--- branches/gnumeric-1-8/src/wbc-gtk.c	(original)
+++ branches/gnumeric-1-8/src/wbc-gtk.c	Sun May  4 13:57:11 2008
@@ -763,7 +763,14 @@
 
 	cb_direction_change (NULL, NULL, new_scg);
 
-	if (wbcg_rangesel_possible (wbcg)) {
+	if (wbcg_is_editing (wbcg) && wbcg_rangesel_possible (wbcg)) {
+		/*
+		 * When we are editing, sheet changes are not done fully.
+		 * We revert to the original sheet later.
+		 *
+		 * On the other hand, when we are selecting a range for a
+		 * dialog, we do change sheet fully.
+		 */
 		scg_take_focus (new_scg);
 		return;
 	}