gnumeric r16551 - in trunk: . src

[mortenw svn gnome org]

Author: mortenw
Date: Sun May  4 13:56:19 2008
New Revision: 16551
URL: http://svn.gnome.org/viewvc/gnumeric?rev=16551&view=rev

Log:
2008-05-04  Morten Welinder  <terra gnome org>

	* src/wbc-gtk.c (cb_notebook_switch_page): When selecting a range
	for a dialog, do sheet changes fully.  Fixes #529309.



Modified:
   trunk/ChangeLog
   trunk/NEWS
   trunk/src/wbc-gtk.c

Modified: trunk/NEWS
==============================================================================
--- trunk/NEWS	(original)
+++ trunk/NEWS	Sun May  4 13:56:19 2008
@@ -75,6 +75,7 @@
 	* Implement F9 for evaluating a selected subexpression.
 	* Fix problem loading Quattro Pro files.  [#530183]
 	* Fix right/center text for Quattro Pro files.
+	* Fix problem with sheet changes during range selection.  [#529309]
 
 Nick Lamb:
 	* Honour detachable-toolbar preference.  [#321867]

Modified: trunk/src/wbc-gtk.c
==============================================================================
--- trunk/src/wbc-gtk.c	(original)
+++ trunk/src/wbc-gtk.c	Sun May  4 13:56:19 2008
@@ -763,7 +763,14 @@
 
 	cb_direction_change (NULL, NULL, new_scg);
 
-	if (wbcg_rangesel_possible (wbcg)) {
+	if (wbcg_is_editing (wbcg) && wbcg_rangesel_possible (wbcg)) {
+		/*
+		 * When we are editing, sheet changes are not done fully.
+		 * We revert to the original sheet later.
+		 *
+		 * On the other hand, when we are selecting a range for a
+		 * dialog, we do change sheet fully.
+		 */
 		scg_take_focus (new_scg);
 		return;
 	}