Hi Nick On 2013-01-07 08:54, nick black <nick black sprezzatech com> wrote:
David King left as an exercise for the reader: OK, I think i got it (haven't had time to test, and am *NOT* an expert with vala). I'm using GLib collections now. I don't think this is the right way to go -- you want to use the best collections possible -- but it ought work, from what I can tell. Please apply after verifying they work -- I'll be able to check it out later tonight. https://github.com/dankamongmen/dankcheese/commit/e5f561b6da246d29ec41735e429c389733b45134 https://github.com/dankamongmen/dankcheese/commit/d409358f16f7460afd9a069987b29e899cb98bd6 https://github.com/dankamongmen/dankcheese/commit/6e1ad975cf7add59c980f1d52b9f1da7c17a84f4
I applied your patches, but when I run Cheese I get many warnings about effects printed to stderr during startup, and the camera widget is not constructed successfully. I did not have time to fix the problem before making a release last night, but if you could take a look and revise your patches I will apply them. The errors that I encountered were:
…(cheese:13142): cheese-CRITICAL **: cheese_effect_get_name: assertion `CHEESE_IS_EFFECT (effect)' failed
(cheese:13142): GLib-CRITICAL **: g_utf8_strdown: assertion `str != NULL' failed
(cheese:13142): cheese-CRITICAL **: cheese_effect_get_name: assertion `CHEESE_IS_EFFECT (effect)' failed
(cheese:13142): GLib-CRITICAL **: g_utf8_strdown: assertion `str != NULL' failed
which was repeated many times. -- http://amigadave.com/
Attachment:
pgpISZujip4eG.pgp
Description: PGP signature