Laurence Urhegyi pushed to branch master at BuildGrid / buildgrid
Commits:
-
3aec6c0d
by Laurence Urhegyi at 2018-10-08T20:16:48Z
1 changed file:
Changes:
| ... | ... | @@ -200,17 +200,19 @@ trunk. |
| 200 | 200 |
Committer access
|
| 201 | 201 |
----------------
|
| 202 | 202 |
|
| 203 |
-We'll hand out commit access to anyone who has successfully landed a
|
|
| 203 |
+We'll hand out commit access to anyone who has successfully landed a single
|
|
| 204 | 204 |
patch to the code base. Please request this via Slack or the mailing list.
|
| 205 | 205 |
|
| 206 |
-This of course relies on contributors being responsive and showing willingness to
|
|
| 207 |
-address any problems that come about after landing branches.
|
|
| 206 |
+This of course relies on contributors being responsive and showing willingness
|
|
| 207 |
+to address any problems that may arise after landing branches.
|
|
| 208 | 208 |
|
| 209 |
-When submitting a patch, please obtain a review from another committer who is
|
|
| 210 |
-familiar with the area of the code base which the branch effects. An approval
|
|
| 211 |
-from someone who is not the patch author will be needed before any merge (we use
|
|
| 212 |
-gitlab's 'approval' feature for this). What we are expecting of committers here
|
|
| 213 |
-in general is basically to escalate the review in cases of uncertainty.
|
|
| 209 |
+When submitting a merge request, please obtain a review from another committer
|
|
| 210 |
+who is familiar with the area of the code base which the branch effects. An
|
|
| 211 |
+approval from another committer who is not the patch author will be needed
|
|
| 212 |
+before any merge (we use gitlab's 'approval' feature for this).
|
|
| 213 |
+ |
|
| 214 |
+What we are expecting of committers here in general is basically to escalate the
|
|
| 215 |
+review in cases of uncertainty.
|
|
| 214 | 216 |
|
| 215 | 217 |
.. note::
|
| 216 | 218 |
|