Laurence Urhegyi pushed to branch master at BuildGrid / buildgrid
Commits:
-
6f82144b
by Laurence Urhegyi at 2018-10-08T20:13:31Z
1 changed file:
Changes:
| 1 |
- |
|
| 2 | 1 |
.. _contributing:
|
| 3 | 2 |
|
| 4 | 3 |
Contributing
|
| ... | ... | @@ -201,20 +200,17 @@ trunk. |
| 201 | 200 |
Committer access
|
| 202 | 201 |
----------------
|
| 203 | 202 |
|
| 204 |
-We'll hand out commit access to anyone who has successfully landed a single
|
|
| 203 |
+We'll hand out commit access to anyone who has successfully landed a
|
|
| 205 | 204 |
patch to the code base. Please request this via Slack or the mailing list.
|
| 206 | 205 |
|
| 207 |
-This of course relies on contributors being responsive and show willingness to
|
|
| 208 |
-address problems after landing branches there should not be any problems here.
|
|
| 209 |
- |
|
| 210 |
-What we are expecting of committers here in general is basically to escalate the
|
|
| 211 |
-review in cases of uncertainty:
|
|
| 206 |
+This of course relies on contributors being responsive and showing willingness to
|
|
| 207 |
+address any problems that come about after landing branches.
|
|
| 212 | 208 |
|
| 213 |
-- If the change is very trivial (obvious few line changes, typos…), and you are
|
|
| 214 |
- confident of the change, there is no need for review.
|
|
| 215 |
-- If the change is non trivial, please obtain a review from another committer
|
|
| 216 |
- who is familiar with the area which the branch effects. An approval from
|
|
| 217 |
- someone who is not the patch author will be needed before any merge.
|
|
| 209 |
+When submitting a patch, please obtain a review from another committer who is
|
|
| 210 |
+familiar with the area of the code base which the branch effects. An approval
|
|
| 211 |
+from someone who is not the patch author will be needed before any merge (we use
|
|
| 212 |
+gitlab's 'approval' feature for this). What we are expecting of committers here
|
|
| 213 |
+in general is basically to escalate the review in cases of uncertainty.
|
|
| 218 | 214 |
|
| 219 | 215 |
.. note::
|
| 220 | 216 |
|