[Notes] [Git][BuildStream/buildstream][master] 2 commits: Catch correct exception from shutil.rmtree

[Valentin David <gitlab mg gitlab com>]

Title: GitLab

Valentin David pushed to branch master at BuildStream / buildstream

Commits:

• a7984218
  by Valentin David at 2018-10-04T14:56:09Z

  Catch correct exception from shutil.rmtree
  
  Python documentation is not clear on what shutil.rmtree is supposed to
  raise. However from the source code, it is obvious that OSError are
  raised, but never shutil.Error.
  
  It is not easy to test in normal condition because issues happen
  usually in combination with a FUSE filesystem, a probably a race
  condition where `fstatat` returns an error just before the filesystem
  being unmounted.
  
  Fixes #153.
  

• b7b20d9e
  by Valentin David at 2018-10-04T15:31:22Z

  Merge branch 'valentindavid/rmtree_oserror' into 'master'
  
  Catch correct exception from shutil.rmtree
  
  Closes #153
  
  See merge request BuildStream/buildstream!849

1 changed file:

• buildstream/utils.py

Changes:

buildstream/utils.py

---

...	...	@@ -686,7 +686,7 @@ def _force_rmtree(rootpath, **kwargs):
686	686
687	687	try:
688	688	shutil.rmtree(rootpath, **kwargs)
689		- except shutil.Error as e:
	689	+ except OSError as e:
690	690	raise UtilError("Failed to remove cache directory '{}': {}"
691	691	.format(rootpath, e))
692	692

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.