[Notes] [Git][BuildStream/buildstream][bst-1.2] 2 commits: Catch correct exception from shutil.rmtree

[Valentin David <gitlab mg gitlab com>]

Title: GitLab

Valentin David pushed to branch bst-1.2 at BuildStream / buildstream

Commits:

• 26d48cc9
  by Valentin David at 2018-10-04T14:55:13Z

  Catch correct exception from shutil.rmtree
  
  Python documentation is not clear on what shutil.rmtree is supposed to
  raise. However from the source code, it is obvious that OSError are
  raised, but never shutil.Error.
  
  It is not easy to test in normal condition because issues happen
  usually in combination with a FUSE filesystem, a probably a race
  condition where `fstatat` returns an error just before the filesystem
  being unmounted.
  
  Fixes #153.
  

• 96f09d48
  by Valentin David at 2018-10-04T15:16:46Z

  Merge branch 'valentindavid/rmtree_oserror-1.2' into 'bst-1.2'
  
  Catch correct exception from shutil.rmtree [bst-1.2]
  
  See merge request BuildStream/buildstream!861

1 changed file:

• buildstream/utils.py

Changes:

buildstream/utils.py

---

...	...	@@ -679,7 +679,7 @@ def _force_rmtree(rootpath, **kwargs):
679	679
680	680	try:
681	681	shutil.rmtree(rootpath, **kwargs)
682		- except shutil.Error as e:
	682	+ except OSError as e:
683	683	raise UtilError("Failed to remove cache directory '{}': {}"
684	684	.format(rootpath, e))
685	685

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.