Re: [BuildStream] [Git][BuildStream/buildstream][135-expire-artifacts-in-local-cache] _context.py: Add simpler message handlers

[Sander Striker <s striker striker nl>]

Hi,

I'm a bit pasionate about this one:)  I think it's actually desirable to limit this to commits only.  And only those directly related to the codebase. I fear that notifications is too broad of a description and too inviting to send more things to it later.

Cheers,

Sander

On Wed, Jul 25, 2018, 15:43 Agustín Benito Bethencourt via Buildstream-list <buildstream-list gnome org> wrote:

Hi,

a new mailing list for receiving the commits from Gitlab has been created:
buildstream-notifications-list gnome org

If you are interested in receiving the commits via mail, please join the list:
https://mail.gnome.org/mailman/listinfo/buildstream-notifications-list

Currently only the following repos has been configured to send push events to
the mailing list:
* Top tree
** buildstream
* nosoftware subgroup
** alignment
** communication

Key configurations of the mailing list: https://gitlab.com/BuildStream/
nosoftware/alignment/issues/23#mailing-list-key-configurations

Unless somebody strongly opposes, I will add the rest of the repos from the
buildstream project to the notification list. They add in general little traffic.

On Tuesday, 10 July 2018 16:42:26 CEST Agustín Benito Bethencourt via
Buildstream-list wrote:
> Hi,
>
> please check below what can be sent to the mailing list by default by
> Gitlab. The interesting options available are:
>
> * To include or not the diffs
> * Include more than one recipient. In this case we are talking about the
> mailing list. * More information about the feature:
> https://docs.gitlab.com/ee/user/project/ integrations/emails_on_push.html
>
> As you can see, these mails can be easily filtered since the Subject start
> by
>
> [Git][Group/project]
>
> Please let me know if this is what you want to activate it.
>
> Further functionality requires the usage of Webhooks. I would need the help
> of an engineer for doing more complex/customized stuff.
>
> ######
>
> > Tristan Maat pushed to branch 135-expire-artifacts-in-local-cache at
> > BuildStream / buildstream
> >
> >
> > Commits:
> > a6a7a01f by Tristan Maat at 2018-07-10T14:25:44Z
> > _context.py: Add simpler message handlers
> >
> > - - - - -
> >
> >
> > 13 changed files:
> >
> > - buildstream/_artifactcache/artifactcache.py
> > - buildstream/_context.py
> > - buildstream/_scheduler/jobs/cachesizejob.py
> > - buildstream/_scheduler/jobs/cleanupjob.py
> > - buildstream/_scheduler/jobs/job.py
> > - buildstream/_scheduler/queues/buildqueue.py
> > - buildstream/_scheduler/queues/fetchqueue.py
> > - buildstream/_scheduler/queues/pullqueue.py
> > - buildstream/_scheduler/queues/pushqueue.py
> > - buildstream/_scheduler/queues/queue.py
> > - buildstream/_scheduler/queues/trackqueue.py
> > - buildstream/_scheduler/resources.py
> > - buildstream/_scheduler/scheduler.py
> >
> >
> > Changes:
> >
> > =====================================
> > buildstream/_artifactcache/artifactcache.py
> > =====================================
> >
> > @@ -217,8 +217,10 @@ class ArtifactCache():
> >                  default_conf =
> >                  os.path.join(os.environ['XDG_CONFIG_HOME'],
> >                 
> >                                              'buildstream.conf')
> >                 
> >                  detail = ("There is not enough space to build the given
> >
> > element.\n" -                          "Please increase the cache-quota in
> > {}." -                          .format(self.context.config_origin or
> > default_conf)) +                          "Please increase the cache-quota
> > in {}.\n" +                          "Space usage: {:,} B/{:,} B"
> > +                          .format(self.context.config_origin or
> > default_conf, +
> > self.calculate_cache_size(), self.context.cache_quota))
> >
> >                  if self.calculate_cache_size() >
self.context.cache_quota:
> >                      raise ArtifactError("Cache too full. Aborting.",
> >
> > =====================================
> > buildstream/_context.py
> > =====================================
> >
> > @@ -393,6 +393,30 @@ class Context():
> >          self._message_handler(message, context=self)
> >          return
> >
> > +    def msg(self, text, *, plugin=None, msg_type=None, **kwargs):
> > +        self.message(Message(plugin, msg_type, str(text), **kwargs))
> > +
> > +    def debug(self, text, *, plugin=None, **kwargs):
> > +        self.msg(text, plugin=plugin, msg_type=MessageType.DEBUG,
> > **kwargs) +
> > +    def status(self, text, *, plugin=None, **kwargs):
> > +        self.msg(text, plugin=plugin, msg_type=MessageType.STATUS,
> > **kwargs) +
> > +    def info(self, text, *, plugin=None, **kwargs):
> > +        self.msg(text, plugin=plugin, msg_type=MessageType.INFO,
> > **kwargs)
> > +
> > +    def warn(self, text, *, plugin=None, **kwargs):
> > +        self.msg(text, plugin=plugin, msg_type=MessageType.WARN,
> > **kwargs)
> > +
> > +    def error(self, text, *, plugin=None, **kwargs):
> > +        self.msg(text, plugin=plugin, msg_type=MessageType.ERROR,
> > **kwargs) +
> > +    def bug(self, text, *, plugin=None, **kwargs):
> > +        self.msg(text, plugin=plugin, msg_type=MessageType.BUG, **kwargs)
> > +
> > +    def log(self, text, *, plugin=None, **kwargs):


--
Agustín Benito Bethencourt
Principal Consultant
Codethink Ltd
We respect your privacy.   See https://www.codethink.co.uk/privacy.html
_______________________________________________
Buildstream-list mailing list
Buildstream-list gnome org
https://mail.gnome.org/mailman/listinfo/buildstream-list

--

Cheers,

Sander