Re: Autotools module and mandatory autogen

[Sam Thursfield <sam thursfield codethink co uk>]

On 07/11/17 04:52, Mathieu Bridon wrote:
> I have to admit the difference in treatment surprised me a lot, and I
> can see it leading to a lot of confusion in the future. IMHO if
> BuildStream considers that the autogen step is mandatory, then it
> really should always run it no matter what.
>
> A simple (untested) fix would be to use the following conditionals
> instead:
>
>      if [ -e autogen ]; then ./autogen;
>      elif [ -e autogen.sh ]; then ./autogen.sh;
>      elif [ -e bootstrap ]; then ./bootstrap;
>      elif [ -e bootstrap.sh ]; then ./bootstrap.sh;
>      else autoreconf -ivf;
>      fi
>
> What do people here think? Does this seem important? Or am I just
> blocked on some unjustified need for absolute consistency? :)

I think that change makes sense.

There may be a few elements in projects which break because they have 
declared themselves to use 'autotools' when in fact they don't, but 
those should be fixed anyway.

Sam

--
Sam Thursfield, Codethink Ltd.
Office telephone: +44 161 236 5575