Re: jack-driver updated

[Tim Janik <timj gnu org>]

On 24.08.2017 11:42, Stefan Westerfeld wrote:
>    Hi!
>
> On Wed, Aug 23, 2017 at 06:46:24PM +0200, Tim Janik wrote:
> > this is the version you posted to the list and I was testing:
> >   https://github.com/swesterfeld/beast/tree/jack-driver
>
> That is the correct branch. But still there is something wrong with your checkout.

I presume you refer to commit 4d2ad83e87b40b668909028c8b61cd2f0feb3ee6 ?
(Sometimes it helps to use actual commit ids ;-)

> $ git clone git github com:swesterfeld/beast.git
> ...
> $ cd beast
> $ git checkout jack-driver
> Branch jack-driver set up to track remote branch jack-driver from origin.
> Switched to a new branch 'jack-driver'
> $ egrep '(g_return_if_fail|assert_return)' drivers/bsepcmdevice-jack.cc 
>   assert_return (!self->jack_client, false);

Thanks, *now* I'm seeing the same thing with just:

        git fetch swesterfeld jack-driver:jack-driver

> The branch jack-driver is the branch you need to use.

Yes, thank you. I got that and can also rebase on master without conflicts.

Still, please go back to my email and fix the issues that are *still* remaining,
e.g. "the libjack dependency must be optional" or the various FIXMEs that I
commented on.

>    Cu... Stefan

-- 
Yours sincerely,
Tim Janik

https://testbit.eu/timj/
Free software author.