Re: MERGE: bse2cxx-part3

On 27.07.2011 20:03, Stefan Westerfeld wrote:

On Tue, Jul 26, 2011 at 04:17:37AM +0200, Tim Janik wrote:
On Fri, 22 Jul 2011, Stefan Westerfeld wrote:


I've ported a few bse more sources to C++. Sorry about minor mistakes in the
commit order. Anyway, you can fetch the branch into your bse repo by using:

git fetch bse2cxx-part3:bse2cxx-part3

Thanks, great. I see you put a lot of work in there,
here're my bits:
- please use "uint" in the future, see my other mail.
- remove from compilation rules if another C++ source is present.
- "void * boxed" should be "void *boxed" (unfixed in master)
- pointer casts should be written as: (void*) ptr
   (no extra space between "void" and "*")

Ok. Here is my script, let me know if you need changes to that.

#!/usr/bin/perl -w -pi.bak
s,\bguchar\b,unsigned char,g;

See, what i wrote above, uint8 here...

s,\bgulong\b,unsigned long,g;

This one is worse, rather leave it as gulong and lets go in a seperate step over the code to remove all longs.

s,\bgpointer\b,void *,g;
s,\bgconstpointer\b,const void *,g;
s,parent klass,parent class,g;

I don't get this one, space separation?

    Cu... Stefan


Yours sincerely,
Tim Janik

--- - Founder and CEO of Lanedo GmbH.
Free software author and contributor on various projects.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]