Re: TIMEOUT MERGE: bug-612281 (high frequency arfifacts for 96kHz samples)

On Mon, 5 Jul 2010, Stefan Westerfeld wrote:

On Thu, Jun 24, 2010 at 09:58:06AM +0200, Stefan Westerfeld wrote:

    For a 96k sample, using a filter transition from 18kHz to 24kHz is not optimal
    because this transition band is quite steep, and thus the stopband ripple will
    be quite high. However, for a 96kHz sample we can set the start of the stopband
    to 48kHz, which results in a less steep filter, and better stopband rejection.
    This change improves stopband settings for any wave file with a sample rate >
    48 hHz.


This patch would be mergeable right now by the timeout rule. However while
doing a SpectMorph evaluation, I've found out that it triggers an assertion in
the filter design code, so the patch is probably incorrect. I'll try to figure
out what has gone wrong and send a new merge request.

Ok, please do and feel free to merge after that, since
there's nothing that looks obviously wrong to me.

  Cu... Stefan

Yours sincerely,
Tim Janik


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]