Re: [Banshee-List] [banshee] Re-enable AAC profile bgo#612741

[Bertrand Lorentz <bertrand lorentz gmail com>]

On Wed, Aug 22, 2012 at 6:34 PM, Andres G. Aragoneses <knocte gmail com> wrote:
> On 29/06/12 22:40, gnomeuser gmail com wrote:
>>
>> 2012/6/29 Andres G. Aragoneses <knocte gmail com>:
>>> On 29/06/12 18:24, gnomeuser gmail com wrote:
>>>> 2012/6/29 Andres G. Aragoneses <knocte gmail com>:
>>>>>
>>>>> <snip />
>>>> put out for OS X and Linux will of course be against the new upcoming
>>>> release. Regardless the errors are only for certain aac files and it
>>>> is not fatal as in eating data or crashing Banshee.
>>>
>>> I thought it was causing a crash, sorry.
>>
>> It's still not pretty though, you get files imported with bad or empty
>> tags which leaves the visual experience rather crappy but it is not
>> fatal and with the Last.fm fingerprinter we can typically autocorrect
>> them if I remember correctly.
>
> This one was recently fixed by Alan and *was* causing a crash:
>
> https://github.com/mono/taglib-sharp/commit/e53ffcc4c417bac611fae80d1d0a88ecfafcfc6d
>
> https://bugzilla.gnome.org/show_bug.cgi?id=676934
>
> So should we reconsider about tagging new taglib-sharp and make banshee 2.5
> depend on it?

That fix is already included in the latest taglib-sharp release:
http://download.banshee.fm/taglib-sharp/2.1.0.0/taglib-sharp-2.1.0.0.news

As for bumping dependencies to get bug fixes, I'm not in favor of that
in general, for the following reasons:
1/ Version requirements checked by ./configure are about what is
necessary to be able to build. Additional runtime requirements are
about what's needed to get some features.
The "get the latest version of the deps to get the latest bugfixes" is
implied, kind of.
2/ Distros might already have the bugfix backported to the version of
the library they ship, so bumping the dep only brings pain to the
packagers, and no benefit to their users.
3/ Even if it's during a development phase, it makes it harder for
potential contributor to build Banshee from git master. From what I
heard, this is the main issue with contributing to the GNOME core
apps. I'm tempted to call it the "OMG! I need to build the whole world
with jhbuild" syndrom ;)

As I said, it's a general guideline, not an absolute rule. If the
bugfix prevents a systematic crash on startup, then it's another
story.

And also, this is in the context of how we currently ship apps on
Linux, which is not perfect either...

-- 
Bertrand Lorentz