Re: [Banshee-List] Report on pending patches Issue 01/2011



Hi,

There is the dvd patch too:
https://bugzilla.gnome.org/show_bug.cgi?id=549568
patch in it or all on github.

As a lot of other open source project, Banshee need more maintainers and of course more time for maintainers.
AFAIK, Gabriel is the only one working full time on Banshee and he have a lot to manage.

Maintainer have all a real life outside... Maybe a more pyramidal solution with some active contributors to filter patch with a first review (typo, coding guidline, unit testing) or by component can simplify work for maintainers.
It is sad to see so much patch blocked but each patch can add new bugs so can not been review quickly...


cheers,

Olivier Dufour


On Fri, May 20, 2011 at 10:55 AM, Frank <funtastix googlemail com> wrote:
Motivation: I have submitted a couple of patches during the past weeks
and months the progress of which has stalled. This initially led to a
temporary lack of enthusiasm for the active participation in the
project (although I never close the bugs/enhancement that I still find
worth implementing and that I want to give a shot). After that, it led
me into investigating what way proposed patches for Banshee go in the
community and with the busy maintainers (especially in those times of
big changes right now). I discovered there is a good bunch of patches
pending and waiting for some action and it is quite tedious to follow
them all through their separate mailings and occasional
updates/comments, not to mention to find those issues that need
action. This finally motivate me to go through all unreviewed patches,
analyse their current state and compile the following report to help
get those "almost-there" issues to make their final steps. If desired
I could try to create a report in this manner in intervals, even
though they might not always be regular.

This is a report about pending (unreviewed) patches for Banshee
bugs/enhancement requests that seem to have stalled even though being
actually in their final stages.

The patches are sorted by age, and some are quite old, so I also tried
to evaluate if they still apply, but I have not actually tested any of
them (except the ones I provided).

There is a lot of patches that need maintainer's decisions, but
other's just need some bold user's to test it.

There is an overview available for all patches pending review which I
took as basis for this report:
https://bugzilla.gnome.org/page.cgi?id=patchreport.html&product=banshee&max_days=30000

Disclaimer: All comments about the bugs are my very personal opinions
after looking into each issue and trying to analyse its status.
Patches I consider in their final stages have usually been through a
couple of reviews and/or tests (depending on complexity).

Component: Device - USB Mass Storage (4)
----------------------------------------

* These patches should be marked as "reviewed -- needs work" by either
Gabriel or corec
[https://bugzilla.gnome.org/show_bug.cgi?id=568129]
ID3 v2.3 Tag Support (Normal / normal)
--> [https://bugzilla.gnome.org/attachment.cgi?id=163473action=diff]
(340 days) Patch to enable selection of id3mux and settings for it
--> [https://bugzilla.gnome.org/attachment.cgi?id=163474action=diff]
(340 days) fix the cornercase of enabling and disabling of checkbox

* These patches need maintainer review/signoff
[https://bugzilla.gnome.org/show_bug.cgi?id=624922]
Read-Only collection DAP sync (Normal / enhancement)
--> [https://bugzilla.gnome.org/attachment.cgi?id=166342action=diff]
(301 days) Add Read-Only Library Syncing
--> [https://bugzilla.gnome.org/attachment.cgi?id=166343action=diff]
(301 days) Falback to Read-Only Sync panic button


Component: general (14)
-----------------------

* This patch is in its final stage(s) and needs maintainer review/signoff
[https://bugzilla.gnome.org/show_bug.cgi?id=577772]
Revamp the job scheduling (Banshee.Kernel and UserJob*) (High / enhancement)
--> [https://bugzilla.gnome.org/attachment.cgi?id=176112action=diff]
(160 days) patch revamp metadata jobs 2

* This patch needs maintainer signoff
[https://bugzilla.gnome.org/show_bug.cgi?id=630387]
Shouldn't add /usr/lib to LD_LIBRARY_PATH (Normal / normal)
--> [https://bugzilla.gnome.org/attachment.cgi?id=171019action=diff]
(236 days) Patch expanded_libdir out of LD_LIBRARY_PATH

* This patch (not the bug) is obsolete AFAIK with the work olivier
dufour is doing
[https://bugzilla.gnome.org/show_bug.cgi?id=536656]
Video support should be an extension (Normal / enhancement)
--> [https://bugzilla.gnome.org/attachment.cgi?id=178402action=diff]
(123 days) video as an extension

* This patch (not the bug) is obsolete AFAIK with the work olivier
dufour is doing
[https://bugzilla.gnome.org/show_bug.cgi?id=631772]
Video should have support for movies/tv-shows (Normal / enhancement)
--> [https://bugzilla.gnome.org/attachment.cgi?id=181179action=diff]
(90 days) video patch

* This patch has a design issue and is awaiting maintainer's answer
[https://bugzilla.gnome.org/show_bug.cgi?id=644270]
Uncaught exception crashes Banshee if the log cannot be opened (Normal / normal)
--> [https://bugzilla.gnome.org/attachment.cgi?id=182913action=diff]
(70 days) Patch to suppress exceptions when opening the log file

* These patches needs testing on different IDEs -- volunteers welcome
[https://bugzilla.gnome.org/show_bug.cgi?id=644612]
Visual Studio 2010 Compatibility (Normal / normal)
--> [https://bugzilla.gnome.org/attachment.cgi?id=183262action=diff]
(66 days) Patch to add VS2010 compatibility to the Hyena solution
--> [https://bugzilla.gnome.org/attachment.cgi?id=184521action=diff]
(50 days) Patch to add VS2010 compatibility to the Banshee solution

* This patch has been updated after review and need's a new maintainer review
[https://bugzilla.gnome.org/show_bug.cgi?id=638583]
Pause playback on suspend/hibernate, and resume playback with long fad
(Normal / normal)
--> [https://bugzilla.gnome.org/attachment.cgi?id=186206action=diff]
(30 days) power management patch

* This patch needs a review, probably best by Bertrand
[https://bugzilla.gnome.org/show_bug.cgi?id=636071]
Banshee.PlayQueue doesn't support for enqueue non-library files
(Normal / normal)
--> [https://bugzilla.gnome.org/attachment.cgi?id=187395action=diff]
(12 days) Patch over opening uris method

* This patch is very simple and should be committed.
[https://bugzilla.gnome.org/show_bug.cgi?id=650325]
"http://banshee-project.org/Guide/DAPs/MTP" page already doesn't exist
(Normal / trivial)
--> [https://bugzilla.gnome.org/attachment.cgi?id=187920action=diff]
(2 days) Delete URL patch
--> [https://bugzilla.gnome.org/attachment.cgi?id=187921action=diff]
(2 days) Delete URL patch


Component: Metadata (1)
-----------------------

* This patch (not the bug) is most likely obsolete AFAIK with the work
olivier dufour is doing and "needs work" as the developer himself says
[https://bugzilla.gnome.org/show_bug.cgi?id=552992]
Video Metadata (Normal / enhancement)
--> [https://bugzilla.gnome.org/attachment.cgi?id=172360action=diff]
(216 days) Patch for handling video-specific metadata


Component: Other Extensions (5)
-------------------------------

* This bug/patch should be obsolete when Gst# is merged, so should be
Resolved/Won't fix
[https://bugzilla.gnome.org/show_bug.cgi?id=620073]
compilation fails with clutter enabled playback with clutter 1.2.8
(Normal / normal)
--> [https://bugzilla.gnome.org/attachment.cgi?id=162823action=diff]
(347 days) The patch that fixes compilation errors with banshee

* This patch is simple, but waiting for the library watcher to work
flawlessly. Mark as reviewed?
[https://bugzilla.gnome.org/show_bug.cgi?id=638939]
Enable the library watcher by default (Normal / enhancement)
--> [https://bugzilla.gnome.org/attachment.cgi?id=177783action=diff]
(131 days) proposed patch

* This patch is in its final stage and needs last maintainer's review
[https://bugzilla.gnome.org/show_bug.cgi?id=634717]
Have banshee treat playing from filesystem like totem does (Normal / normal)
--> [https://bugzilla.gnome.org/attachment.cgi?id=184930action=diff]
(46 days) add an auto-clear option that clears the queue when new
files are open

* This (reworked) patch needs review by a maintainer. It's a bug that
crashes Banshee.
[https://bugzilla.gnome.org/show_bug.cgi?id=648839]
Closing Metadata Fixer can cause segfault; TreeStore.gtk_tree_model_ge
(Normal / major)
--> [https://bugzilla.gnome.org/attachment.cgi?id=187548action=diff]
(8 days) An alternate fix that simply ensures highlight_iter is
updated when th


Component: Podcasting (3)
-------------------------

* Following the discussion, should these patches be marked as "needs work"?
[https://bugzilla.gnome.org/show_bug.cgi?id=492900]
Patch that supports password protected podcasts (Normal / normal)
--> [https://bugzilla.gnome.org/attachment.cgi?id=172113action=diff]
(219 days) partial patch
--> [https://bugzilla.gnome.org/attachment.cgi?id=172129action=diff]
(219 days) 2cd patch

* This patch needs review after fixes for the first review by Bertrand
[https://bugzilla.gnome.org/show_bug.cgi?id=553203]
Automatically delete old podcast episodes (Normal / enhancement)
--> [https://bugzilla.gnome.org/attachment.cgi?id=173816action=diff]
(195 days) autodelete patch


Component: Smart Playlists (1)
------------------------------

* Is a bug with an ongoing discussion, where the developer has adapted
his patch solution waiting for review
[https://bugzilla.gnome.org/show_bug.cgi?id=563630]
Split 'File Location' field into 'File Path', 'File Location' and 'Fil
(Normal / enhancement)
--> [https://bugzilla.gnome.org/attachment.cgi?id=157932action=diff]
(408 days) Patch v5


Component: User Interface (17)
------------------------------

* This very simple and desirable patch is waiting for a review/commit
for forever and has been pinged a couple of times.
[https://bugzilla.gnome.org/show_bug.cgi?id=549173]
Wish: "Stop When Finished" in the tray icon's popup menu (Normal / enhancement)
--> [https://bugzilla.gnome.org/attachment.cgi?id=129048action=diff]
(818 days) Added "Stop When Finished" menu item to the notification
area menu.

* Seems like Bertrand has reviewed the issue, but not the patch.
Should be marked as "needs work"?
[https://bugzilla.gnome.org/show_bug.cgi?id=593307]
Always show "Videos" section for supported devices (Normal / normal)
--> [https://bugzilla.gnome.org/attachment.cgi?id=142340action=diff]
(623 days) Proposed fix.

* This is a controversial patch that needs a maintainer's decision
and/or a last review/commit. (I like it)
[https://bugzilla.gnome.org/show_bug.cgi?id=608879]
Type ahead activation without requiring '?' key press (Normal / enhancement)
--> [https://bugzilla.gnome.org/attachment.cgi?id=162720action=diff]
(348 days) Type ahead activation without requiring '?' key press

* This is still more a discussion than a bug, but the patch seems to
be bad GUI design, so should that go to "needs work"?
[https://bugzilla.gnome.org/show_bug.cgi?id=635892]
Shuffle drop down menu can be confusing and is undiscoverable (Normal / normal)
--> [https://bugzilla.gnome.org/attachment.cgi?id=175333action=diff]
(172 days) Move shuffle and repeat to bottom of interface

* Does this patch collide with olivier dufour's work on video?
[https://bugzilla.gnome.org/show_bug.cgi?id=535911]
File Policies (copy files to folders) should be source-specific (Normal / minor)
--> [https://bugzilla.gnome.org/attachment.cgi?id=182389action=diff]
(76 days) Import Settings only on Video and Audio Source

* This patch is in its final stages and needs a last maintainer's review/commit
[https://bugzilla.gnome.org/show_bug.cgi?id=646765]
Artist Browser is just text and hard to locate an artist easily
(Normal / enhancement)
--> [https://bugzilla.gnome.org/attachment.cgi?id=185484action=diff]
(41 days) add optional cover art in two sizes to the artist list view

* This patch needs review and testers
[https://bugzilla.gnome.org/show_bug.cgi?id=526994]
Easy rating for song being played (Normal / enhancement)
--> [https://bugzilla.gnome.org/attachment.cgi?id=185631action=diff]
(38 days) Added RatingEntry object to SeekSlider

* This patch needs a maintainer's review/signoff
[https://bugzilla.gnome.org/show_bug.cgi?id=647129]
AlbumGrid/SortAlbumByYear: move configuration UI from Preferences to V
(Normal / enhancement)
--> [https://bugzilla.gnome.org/attachment.cgi?id=186704action=diff]
(21 days) patch to move configuration UI to view menu

* This patch implements the maintainer's suggestion and needs a review
[https://bugzilla.gnome.org/show_bug.cgi?id=466435]
Playlists View (Normal / enhancement)
--> [https://bugzilla.gnome.org/attachment.cgi?id=186705action=diff]
(21 days) patch to show playlists insensitve that contain all selected
tracks

* This simple patch needs a review/signoff/commit
[https://bugzilla.gnome.org/show_bug.cgi?id=638475]
Rating cell causes warning on mouseover (Normal / normal)
--> [https://bugzilla.gnome.org/attachment.cgi?id=186779action=diff]
(21 days) This patch makes ListView create a CanvasManager and assign
it to all

* This simple patch (which can delete wrong files) needs maintainer's
review/signoff/commit.
[https://bugzilla.gnome.org/show_bug.cgi?id=620944]
Track change during deletion causes deletion of wrong file (Normal / major)
--> [https://bugzilla.gnome.org/attachment.cgi?id=186923action=diff]
(18 days) Check if track context menu is open before letting Banshee
change trac

* This patch needs review and testers as well as a maintainer's opinion
[https://bugzilla.gnome.org/show_bug.cgi?id=540873]
Allow changing browser filters; add/remove genre, album artist, year,
(Normal / enhancement)
--> [https://bugzilla.gnome.org/attachment.cgi?id=187970action=diff]
(1 days) v3 of configurable artist/album browser with genre, artist
and albumar
--> [https://bugzilla.gnome.org/attachment.cgi?id=187971action=diff]
(1 days) part2 of patch: add an optional year filter
_______________________________________________
banshee-list mailing list
banshee-list gnome org
http://mail.gnome.org/mailman/listinfo/banshee-list  (unsubscribe here)



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]