Re: [Banshee-List] 'notify-sharp' window pops up on song change?



On Thu, 2009-05-21 at 20:51 +1000, Alexander Kojevnikov wrote:
> 
> This is because you have notify-sharp installed and banshee picks it
> up instead of the (fixed) copy it comes with. See
> http://bugzilla.gnome.org/show_bug.cgi?id=572601 (and
> http://bugzilla.gnome.org/show_bug.cgi?id=580064 for a work-around)

I believe you are mistaken. The bug in question is
http://bugzilla.gnome.org/show_bug.cgi?id=571177.

The original patch from this bug which was applied fixed it at the wrong
place. Instead of making Banshee.NotificationArea check for actions, it
changed the in-tree notify-sharp to check for actions. The newest patch
in that bug changes this, so that Banshee.NotificationArea is the one
which checks for actions support, and not notify-sharp.

As I understand it, that particular patch could not be applied at first,
because it broke compilation with the in-tree notify-sharp, i.e. it
required a feature that the in-tree notify-sharp did not have. This
changed when the in-tree notify-sharp was removed, in favour of using an
external (newer) notify-sharp. Later, a newer version of notify-sharp
was re-included in the Banshee source tree. The commits in question are:
b1ccfb3f28155270d3d4ea0f8fce88acd192b8b4 (the patch in question),
b28f9d36425e5c4260561316efe6dc6986642a42 (remove in-tree notify-sharp),
and 39d4f5b2bf26fd4b630120018ba84b85ec45f834 (bring a new version of
notify-sharp into Banshee's source tree).
-- 
Regards,
Chow Loong Jin

Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]