Re: [Banshee-List] Importers 1.5 broken



2009/6/3 Ruud v A <banshee veniogames com>:

> This patch works :D

Thanks for testing!

> It works different than mine but it also solves some problems I hadn't dealt
> with yet. Mine had one advantage though: it scanned your computer for
> installed iTunes versions and then compares user names etc. to find an
> iTunes library. If none is found, CanImport returned false.

How fast is it? CanImport is called each time the Import dialogue
opens, does it slow it down?

> Also the
> checkboxes wheter to import ratings etc. is unnecessary; why would you
> uncheck this while importing? So I think the entire dialog could be left out
> and the importer could be made more intelligent.

See comments 25-27 in bgo#532650, it looks like *not* importing the
ratings, etc can sometimes be useful.

> There is one remark: if the user completely switches to Banshee and
> uninstalls iTunes but backups his library file, my importer won't find it.
> This would only work if the user keeps his music in a separate folder.

That IMHO is a major limitation. This wouldn't work if for example the
user wants to import her iTunes library to a brand new Linux box.

> The importer is great but it could be made a lot "smarter" so it requires
> less input from the user and just imports.
>
> I am currently working on implementing that for the patch, but do you think
> it would be an improvement?

Auto-discovery of the iTunes library file would be useful if it works
fast enough.

> P.S is this included for 1.5?

No.

> P.P.S the Rythmbox importer still doesn't work, though I have used Rythmbox.
> In 1.4 it did work.

What exactly doesn't work? Is it the inclusion of the PlayerMigration
project into the solution or something else? Could you file a bug if
the latter?


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]