Re: [Banshee-List] Rythmbox libary import

[Paul Lange <palango gmx de>]

Andrew Conkling schrieb:
> On Tue, Sep 30, 2008 at 6:49 PM, Gabriel Burt <gabriel burt gmail com 
> <mailto:gabriel burt gmail com>> wrote:
>
>     Please open a bug on bugzilla and attach your work there, and we'll
>     continue the discussion there too.  See
>     http://banshee-project.org/contribute/write-code/ for more info.
>
>
> Paul, I think this bug is yours? 
> http://bugzilla.gnome.org/show_bug.cgi?id=554511 If so, can you attach 
> your work there? As per the link Gabe referred to above, you can use 
> the `svn diff` command to produce a patch, though I think you'll need 
> to use the `diff -u /dev/null` method to refer to your new import 
> source file. If it's easier, let me know and I can probably produce a 
> working patch and upload it to the bug.
>
> Don't mean to be a nitpick, just want to make sure this doesn't get 
> lost. Looks awesome! (I had referred a friend to the import fanciness 
> a while back only to find out that it was no longer present.)

I appended a first patch. It threw a lot of errors for me (at line 146 
in RhythmboxPlayerImportSource.cs) and imported rated songs multiple 
(6x) times. But there's also an "Importing Media" Job running so I don't 
know what is causing this.

Another thing I noticed it that in ImportSourceManager there now are 
calls for every PlayerImporter. Maybe it would be clever to create an 
extension point therefore.

A last question: The importer currently only imports songs. How  should 
it handle Podcasts/Radio-Streams. Is there a way to only import them if 
the corresponding extensions are enabled?

Looking forward to feedback :)
Paul

ps. Do I need to class make clean; ./autogen.sh, make, make run after 
every change or is there a simple way?