Re: [Banshee-List] Pending Patches Periodical (Issue 2)

["Bob Copeland" <me bobcopeland com>]

2008/7/29 Bertrand Lorentz <bertrand lorentz gmail com>:
> On Tue, 2008-07-29 at 13:48 -0500, Gabriel Burt wrote:
>> > 541828 - Karma DAP support is not in 1.0
>> > http://bugzilla.gnome.org/show_bug.cgi?id=541828
>> > Adds support for Rio Karma back to banshee.
>> > Needs testing
>>
>> Do you have a Rio device?  I don't, so I can't test.  Let's keep this
>> patch review e-mail more focused on patches that need maintainer
>> review and/or are ready to commit (by your or other contributors'
>> judgement).  Also, might be helpful to mention who wrote or reviewed
>> the patch, if it's somebody who is a regular contributor.
>
> I don't have a Rio, so I was trying to get some feedback on the patch.

For what it's worth, I've had two success reports with the Rio patch,
one in the bugzilla report and one offline, plus of course myself
makes three.  As the bugzilla notes, detection is a little wrong; it
works best when plugged in at Banshee startup -- but IMHO any support
at all is better than none.  Unfortunately the karmas aren't made any
more and are increasingly rare, so the user community may remain
vanishingly niche.

I'm willing to keep maintaining the patch whenever someone asks me to
update it, whether or not it goes upstream, but it would be nice to
get some feedback.

-- 
Bob Copeland %% www.bobcopeland.com