GNOME.org
 

Re: [Banshee-List] ShowTrackOnChange Plugin - Updated, 0.3

Nick,
Fixed a little issue for you - the configure.ac file only handled banshee 0.10.x - attached is a patch that will make the stoc plugin work well with CVS HEAD (what will become 0.11.x in the coming weeks).
Also, when you want to make a release tarball - run 'make dist' or 'make dist-bzip2' - this will make the configure script and it's prerequisites, and you won't have to ship autogen.sh. Ask me if this doesn't make sense :)
Also, linked below are some screenies from a dual monitor setup. Take these with a grain of salt - this is dual head with the radeon driver's "pseudo-xinerama" which in my mind means "it sorta works, but not really". This problem may not happen on a proper xinerama setup. When I have the left-offset set to something that's on my second monitor (see prefs shot [1]), and the "snap to" option set, it snaps to the very left of my left monitor [2]. Don't know what's causing that. Also - the Xdelta gconf key is always some negative number like -150 whenever I have the box on the right screen - and it never changes value as I move the box around. Here's a dump of my gconf keys: 

$ gconftool-2 -R /apps/Banshee/ShowTrackOnChange
 X = 1900
 Y = 30
 Snap = true
 Monitor = 1
 XDelta = -150
 Seconds = 10
 YDelta = 30
 Enabled = true
To make it better - with snap set to false and the position set to my right monitor - I don't get a popup at all.
For something you may want to aspire to...check out liferea's popup notifications[3], as well as mail-notification applet's popup notifications [4]. mail-notification is perfect, IMO. Also note that when the v-offset is set to zero, it does NOT overlap my gnome-panel. 

So...here's my formal feature request list:
1) Make the notification box area preferences more user-centric
2) See what you can do about the issues with my second monitor, if anything :)
3) Apply attached patch and release 0.3.1 - CVS/HEAD people will thank you :)

Hope I was descriptive enough.  Email back if you have any questions!

Good work on this :)

Cheers,

Patrick

[1] http://trick.vanstaveren.us/tmp/preview.png
[2] http://trick.vanstaveren.us/tmp/actual.png
[3] http://trick.vanstaveren.us/tmp/liferea-prefs-notification.png
[4] http://trick.vanstaveren.us/tmp/mail-notification-popup.png

--
Patrick "Trick" van Staveren
http://trick.vanstaveren.us


----- Message from nick den-4 com ---------
    Date: Sat, 22 Jul 2006 02:57:34 -0500
    From: Nick Bargnesi <nick den-4 com>
Reply-To: banshee-list gnome org
 Subject: [Banshee-List] ShowTrackOnChange Plugin - Updated, 0.3
      To: Banshee List <banshee-list gnome org>



Greetings again!

I've released a 0.3 version of the ShowTrackOnChange plugin.  The big change
is 0.3 allows popups to be snapped to screen regions, deprecating the need
for right aligning trickery.  Should also fix some issues with multiple
monitors - be interested in receiving reports both good and bad from anyone
using it with multiple displays.

Info, download, and ChangeLog here: http://www.den-4.com/node/13

--
Nick Bargnesi
nick den-4 com
Den 4 F/OSS Developer and Co-Founder
http://www.den-4.com

Den 4 Software is a group of open source software engineers dedicated to
giving back to the F/OSS community.

Join here:
http://www.den-4.com/user/register



----- End message from nick den-4 com -----



--- banshee-showtrackonchange-plugin-0.3/configure.ac	2006-07-22 04:19:38.000000000 -0400
+++ banshee-sample-plugin/configure.ac	2006-07-27 00:52:50.000000000 -0400
@@ -5,26 +5,71 @@
 
 AM_MAINTAINER_MODE
 
-AC_PATH_PROG(MONO, mono, no)
-if test "x$MONO" = "xno"; then
-	AC_MSG_ERROR([Cannot find "mono" runtime in your PATH])
+MONO_REQUIRED_VERSION=1.1.13
+PKG_CHECK_MODULES(MONO, mono >= $MONO_REQUIRED_VERSION)
+
+dnl Mono programs
+MONODIR=`$PKG_CONFIG --variable=exec_prefix mono`
+MONOBIN="$MONODIR/bin"
+MONO="$MONOBIN/mono"
+MCS="$MONOBIN/mcs"
+GMCS="$MONOBIN/gmcs"
+
+if test ! -x "$MONO"; then
+	AC_MSG_ERROR([No Mono runtime found])
+fi
+
+CS="C#"
+if test ! -x "$MCS"; then
+	AC_MSG_ERROR([No $CS compiler found])
 fi
 
-AC_PATH_PROG(MCS, mcs, no)
-if test "x$MCS" = "xno"; then
-	AC_MSG_ERROR([Cannot find "mcs" compiler in your PATH])
+if test ! -x "$GMCS"; then
+	AC_MSG_ERROR([No $CS 2.0 (gmcs) compiler found])
 fi
 
+MCS_FLAGS="-debug"
+
+dnl Banshee deps
 PKG_CHECK_MODULES(BANSHEE, banshee >= 0.10.2)
 AC_SUBST(BANSHEE_LIBS)
 
+if test "x`$PKG_CONFIG --variable=pluginapi banshee`" = "x2"; then
+	banshee_0_10="no"
+	MCS=$GMCS
+	AM_CONDITIONAL(BANSHEE_0_10, false)
+else
+	banshee_0_10="yes"
+	MCS_FLAGS="$MCS_FLAGS -define:BANSHEE_0_10"
+	AM_CONDITIONAL(BANSHEE_0_10, true)
+fi
+
+AC_SUBST(MCS_FLAGS)
+AC_SUBST(MCS)
+AC_SUBST(MONO)
+
 AC_ARG_ENABLE(user-plugin, AC_HELP_STRING([--enable-user-plugin], [Install plugin into user-level Banshee plugins directory instead of the Banshee system plugins directory]), , enable_user_plugin="no")
 
-PLUGINDIR=`$PKG_CONFIG --variable=systemplugindir banshee`
+dnl Banshee Plugins Path
+SYSTEM_PLUGINS=`$PKG_CONFIG --variable=systemplugindir banshee`
+REL_PLUGINS_DIR=`basename $SYSTEM_PLUGINS`
+REL_BANSHEE_DIR=`echo "$SYSTEM_PLUGINS" | sed -e "s|\/$REL_PLUGINS_DIR||"`
+REL_BANSHEE_DIR=`basename $REL_BANSHEE_DIR`
+REL_PLUGINS_DIR=$REL_BANSHEE_DIR/$REL_PLUGINS_DIR
+
+expanded_libdir=`( case $prefix in NONE) prefix=$ac_default_prefix ;; *) ;; esac
+		   case $exec_prefix in NONE) exec_prefix=$prefix ;; *) ;; esac
+		   eval echo $libdir )`
+		   
+PLUGINDIR=$libdir/$REL_PLUGINS_DIR
+expanded_pluginsdir=$expanded_libdir/$REL_PLUGINS_DIR
+
 if test "x$enable_user_plugin" = "xyes"; then
 	PLUGINDIR=`$PKG_CONFIG --variable=userplugindir banshee`
 	PLUGINDIR=`echo "$PLUGINDIR" | sed -e "s|\~|$HOME|"`
+    expanded_pluginsdir=$PLUGINDIR
 fi
+
 AC_SUBST(PLUGINDIR)
 
 AC_OUTPUT([
@@ -33,7 +78,6 @@
 ])
 
 echo "
-Plugin will be installed in $PLUGINDIR
+Plugin will be installed in ${expanded_pluginsdir}
 You should now run \`make'
 ";
-
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]