[Patch] move recheck crypto button to menu, toolbar

Hi all,

attached is a patch which
* moves the “recheck cryptographic content” button from the message headers to the “Message” menu with a 
* lets the user to optionally add a button to the toolbar (main or message window), and
* makes sure that the item (and button) is activated iff any encrypted or signed content is available.

This patch addresses Gitlab ticket 26, but as it seems to be impossible to add me for more than a few minutes 
to the project in that crappy tool, I submit it using the “traditional” (and working!) way… 😉️

Furthermore, the patch fixes a /very/ old issue which prevented the padlock icon being displayed in the 
message list for S/MIME (RFC 8551) signed and/or encrypted messages.

It would be great if a native speaker could review the naming of the toolbar button and the menu item – I am 
sure more accurate English labels would be possible!

Any opinions?


Patch details:
- libbalsa/body.[ch]:
  * add new function libbalsa_message_body_has_crypto_content() which recursively checks if a 
LibBalsaMessageBody contains any not yet decrypted or any signed content which may be rechecked
  * fix comment typo
- libbalsa/gmime-part-rfc2440.c: g_mime_part_check_rfc2440() make sure to lock/unlock a shared stream
- libbalsa/message.[ch]:
  * rename libbalsa_message_is_pgp_(signed|encrypted)() to libbalsa_message_is_(signed|encrypted)(), do not 
export them, and detect S/MIME (RFC 8551) content
  * add and export libbalsa_message_has_crypto_content() to check if a message contains any not yet decrypted 
or any signed content which may be rechecked
- src/balsa-message.[ch]:
  * remove recheck crypto button from bm_header_tl_buttons()
  * rename message_recheck_crypto_cb() to balsa_message_recheck_crypto() and export it
  * remove ancient code relevant for Gtk+-3.0 < 3.15.0 only
- src/main-window.c, src/message-window.c:
  * add “recheck crypto” button to extra toolbar items
  * add recheck crypto callback, and connect it to the menu item
  * appropriately disable/enable menu item and button
- src/toolbar-factory.c: register “Recheck cryptography” button
- ui/main-window.ui, ui/message-window.ui: add menu item to the ui

Attachment: crypto-button_ticket-26.diff.bz2
Description: application/bzip

Attachment: pgpZRHFiavkMT.pgp
Description: PGP signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]