[Patch] fix issue #15: NULL-pointer deref in pop3 code

[Albrecht Dreß <albrecht dress arcor de>]

Hi all,

attached is a trivial patch which fixes the NULL-pointer deref in the pop3 code as reported in [1].  It 
occurs if a POP3 server does not add anything to the initial “+OK” greeting, which is very unusual, but 
perfectly legal according to RFC 1939.

The patch also includes the following changes which do not influence the code behaviour:
- silence a bunch of Flexelint warnings in the siobuf code;
- add missing execute permission to the libnetclient test echo server script.

Cheers,
Albrecht.

[1] <https://gitlab.gnome.org/GNOME/balsa/issues/15>

---
Patch details:
- libnetclient/net-client-pop.c: make sure net_client_pop_read_reply() does not return a NULL server reply 
string on success (fix issue #15)
- libnetclient/net-client-siobuf.c: silence a bunch of Flexelint warnings, no change in code behaviour
- libnetclient/test/echoserver.py: add missing executable flag

Attachment: fix-issue-15.diff
Description: Text Data

Attachment: pgpYKvPekr3Rj.pgp
Description: PGP signature