Re: [Patch] Clear passwords if authentication fails



Hi Albrecht,

On 11/13/2018 03:50:54 PM Tue, Albrecht Dreß wrote:
Hi all,

currently, when the authentication to a server fails, and if the user decided to remember the password, the 
password is kept, and the next authentication attempt will again fail.

Attached is a patch which fixes this behaviour by clearing the respective password for the following 
conditions:
- SMTP: when the server replies with a 534 (Authentication mechanism is too weak) or 535 (Authentication 
credentials invalid) status code (see RFC 4954, Sect. 6)
- POP3: when any error occurs during the authentication phase, as POP3 has no standardised codes indicating 
the status as for SMTP
- user certificate private key: when the key decryption fails

Please note that this patch goes on top of the following pending patches:
* “password dialogue improvements”, submitted on November 4th
* “Fix broken IMAP special folders & other migration issues”, submitted on November 5th

As always, any comment is welcome!

Cheers,
Albrecht.

Many thanks for the patches! And apologies for the delays in testing and pushing them--finished today.

Best,

Peter

Attachment: pgpEIKppPma0M.pgp
Description: PGP signature



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]