Re: GIT version doesn't build anymore

[Jack <ostroffjh users sourceforge net>]

Hello Helmut,

On 2018.07.23 11:19, Helmut Jarausch via balsa-list wrote:
> Hi,
> my last successful build of the GIT version of Balsa was on 2018/07/16
I'm writing this from a fresh compile from a fresh pull from git  
master.  I did have a brief failure of git to connect to the server  
earlier today, but it seemed to be transient.

======= Final configuration =======
 Installing into prefix: /usr/local
Enable compile warnings: true
            HTML widget: webkit2
              Use GNOME: false
           Use Canberra: false
              Use GPGME: true
               Use LDAP: false
                Use GSS: false
             Use SQLite: false
          Spell checker: gtkspell
      Use GtkSourceView: true
           Use Compface: false
          Use libsecret: false
                Use gcr: false
===================================

> But now I encounter problems.
>
> First, in configure.ac it  checks pkg_config enchant-2  which doesn't  
> exist in Gentoo even though enchant-2.1.2 is installed here.
> Therefore it checks for  <= enchant-1.6.0 which fails.
I'm using gtkspell-3.09 patched to use enchant 2.1.1 with patch:
-------------------------
--- /gtkspell/gtkspell.c
+++ /gtkspell/gtkspell.c
@@ -353,7 +353,7 @@
   get_word_extents_from_mark (spell->priv->buffer, &start, &end,  
spell->priv->mark_click);
   word = gtk_text_buffer_get_text (spell->priv->buffer, &start, &end,  
FALSE);

-  enchant_dict_add_to_pwl (spell->priv->speller, word, strlen (word));
+  enchant_dict_add (spell->priv->speller, word, strlen (word));

   gtk_spell_checker_recheck_all (spell);

@@ -1246,7 +1246,7 @@
 void
 gtk_spell_checker_add_to_dictionary (GtkSpellChecker *spell, const  
gchar *word)
 {
-  enchant_dict_add_to_pwl (spell->priv->speller, word, strlen (word));
+  enchant_dict_add (spell->priv->speller, word, strlen (word));
   gtk_spell_checker_recheck_all (spell);
 }
---------------------------
I'll guess that balsa is looking for enchant because you are using the  
internal spell-checker.  I wonder if a similar patch can be used for  
balsa to use the new enchant.  However, I suppose it would also take a  
change to the configure stuff also.

> Disabling this check in configure.ac it fails later on with
>
> /usr/include/webkitgtk-4.0/webkit2/WebKitContextMenuItem.h:64:60:  
> error: unknown type name 'GtkAction'; did you mean 'AtkAction'?
>  webkit_context_menu_item_new                               
> (GtkAction              *action);
>                                                             ^~~~~~~~~
>                                                             AtkAction
> /usr/include/webkitgtk-4.0/webkit2/WebKitContextMenuItem.h:85:61:  
> error: unknown type name 'GtkAction'
>  WEBKIT_DEPRECATED_FOR(webkit_context_menu_item_get_gaction)  
> GtkAction *
>                                                              ^~~~~~~~~
>
> I have webkit-gtk-2.18.6 installed here. Is the patch for this old  
> version removed?
I also have webkit-gtk-2.18.6 (also on Gentoo).  Which patch are you  
referring to?

> I had no problems with the GIT version of 2018/07/16 with the same  
> version of webkit-gtk.
>
> Many thanks for a hint,
> Helmut

Hope this helps at least some.

Jack