Re: [Patch] Enable multi-threaded POP3 retrieval

[Jack <ostroffjh users sourceforge net>]

On 2018.01.05 17:34, Peter Bloomfield wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi Albrecht:
>
> On 01/03/2018 10:11:06 AM Wed, Albrecht Dreß wrote:
> > Hi all,
> >
> > attached is a larger patch which enables multi-threaded retrieval of  
> > POP3 messages.  The biggest part of the patch is related to changes  
> > of the progress dialogue implementation, though.  It also changes  
> > the preferences by replacing the old (retrieve) progress dialogue  
> > options by two simple check boxes for enabling the send and receive  
> > progress, respectively.  As a side effect, we get rid of a bunch of  
> > global variables used for the POP3 progress communication between  
> > the main and retrieval threads which is a lot cleaner IMHO.
>
> Thanks for the patch--that was a lot of effort! It builds and runs  
> for me, and shows progress for my one POP3 host; I can't easily test  
> with multiple hosts, so I pushed it to master for others to test.
But you didn't test the meson build, did you? :-)  I get

Meson encountered an error in file src/meson.build, line 107, column 0:
File threads.h does not exist.

Hopefully I'll be able to figure out the syntax to remove the  
reference, without breaking anything else.
> > BTW, the patch removes the (now obsolete) file src/threads.h.  I  
> > noticed that the file libbalsa/gforest.c is not referenced  
> > everywhere – couldn't we remove it?
>
> I see no reason not to--it's been dead wood for as long as I've known  
> Balsa!
>
> > As always, any comment is welcome!
> >
> > Cheers,
> > Albrecht.
>
> Best,
>
> Peter
> -----BEGIN PGP SIGNATURE-----
>
> iF0EARECAB0WIQS030wPRfNNA5alz3MfX9S1uSp09QUCWk/9iAAKCRAfX9S1uSp0
> 9fxRAJ4qeNZ/dEzHucZ9KpxwcINahez1dACeNVSNPKr7Jaah+N+LyWyjdE1q4oc=
> =IYH0
> -----END PGP SIGNATURE-----
> _______________________________________________
> balsa-list mailing list
> balsa-list gnome org
> https://mail.gnome.org/mailman/listinfo/balsa-list