Re: [Patch] use glib for digest calculations (was: Re: Sv: Balsa release?)



Hi Albrecht:

On 12/29/2016 12:06:24 PM Thu, Albrecht Dreß wrote:
Hi Peter:

Am 29.12.16 17:13 schrieb(en) Peter Bloomfield:
I attached to wrong patch which causes a leak.  Please forget the 1st post, and try this one.

Sorry for the delayed reply. I've installed the patch and built with it, and I'm using the patched Balsa now. 
But I don't seem to have exercised that code path--I sprinkled in some g_messages, and nothing has been 
printed. What would I need to set up in order to actually test it?

For the hmac stuff (imap_auth_cram), you need access to an imap server supporting the 'CRAM-MD5' 
authentication mechanism.  Unfortunately, I don't have access to such a server (dovecot supports it, though), 
so (iirc) I extracted the old and new methods from the source to compare their output.

I tried installing a dovecot server with CRAM-MD5 authentication to test the patch, but I must have messed it 
up--it wouldn't authenticate, but it didn't with the old code either! About to commit...

Best,

Peter


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]