Re: Compiling errors with latest version from GIT, Printing of HTML Messages

[Albrecht Dreß <albrecht dress arcor de>]

Hi John Jack Doe:

Am 14.04.17 18:24 schrieb(en) JohnJackDoe tele2 de:
> 1. I currently run the balsa version 2.5.3a-32-g98a0d88 from GIT. The latest version from GIT is not 
> compiling. Please see the attached display output. Any ideas?

You are compiling on a box where glib's gsize is typedef'ed as "unsigned int", not "unsigned long" as for 
Ubuntu 16.04 LTS/64 bit, and therefore the format specifier is wrong.  Please try the attached patch, which should fix the issue. 
 Note that I /might/ have made the same assumption in other places, too.  You can try 'make -k' after adding the patch to collect 
all of them.  Please tell me if there are more cases like these.  Thanks for pointing me to that!

Side note: I think the "usual" approach by adding the glib-specific format strings (i.e. '_("Message %" G_GSIZE_FORMAT " of 
%" G_GSIZE_FORMAT " (%s of %s)")') will break gettext, see 
<https://www.gnu.org/software/gettext/manual/html_node/Preparing-Strings.html>, so the cast seems to be better to me.  Or does the glib '_()' macro 
cover this case?

> 2. HTML messages are displayed but not printed.

Printing the HTML parts of messages from balsa is not possible (yet).  The only workaround is to open the 
html part in a browser and print from there, with the drawback that it will print the particular part only, 
but neither the envelope nor any other parts.

I guess a fix for that would be difficult, but I'm not familiar with the webkit api.

> I assume that a html2text tool is missing. Is this correct? And what tool is exactly missing?

Html2text (or python-html2text, html2markdown, html2markdown.py2 or html2markdown.py3) is used to extract the 
contents from html-only messages if you want to reply to them only.

Cheers,
Albrecht.

diff --git a/libbalsa/mailbox_pop3.c b/libbalsa/mailbox_pop3.c
index c7a1924..0003b32 100644
--- a/libbalsa/mailbox_pop3.c
+++ b/libbalsa/mailbox_pop3.c
@@ -377,7 +377,8 @@ notify_progress(const struct fetch_data *fd)
        gchar *msgbuf;
 
        recvbuf = libbalsa_size_to_gchar(fd->received);
-       msgbuf = g_strdup_printf(_("Message %lu of %lu (%s of %s)"), fd->msgno, fd->total_messages, recvbuf, 
fd->total_size_msg);
+       msgbuf = g_strdup_printf(_("Message %lu of %lu (%s of %s)"), (unsigned long) fd->msgno, (unsigned 
long) fd->total_messages,
+               recvbuf, fd->total_size_msg);
        g_free(recvbuf);
        libbalsa_mailbox_progress_notify(LIBBALSA_MAILBOX(fd->mailbox), LIBBALSA_NTFY_PROGRESS, fd->received, 
fd->total_size, msgbuf);
        g_free(msgbuf);
@@ -645,7 +646,7 @@ libbalsa_mailbox_pop3_check(LibBalsaMailbox * mailbox)
                        fd.mailbox = mailbox;
                        fd.total_size_msg = libbalsa_size_to_gchar(fd.total_size);
 
-                       msgbuf = g_strdup_printf(_("%lu new messages (%s)"), fd.total_messages, 
fd.total_size_msg);
+                       msgbuf = g_strdup_printf(_("%lu new messages (%s)"), (unsigned long) 
fd.total_messages, fd.total_size_msg);
                        libbalsa_mailbox_progress_notify(mailbox, LIBBALSA_NTFY_PROGRESS, 0, 1, msgbuf);
                        g_free(msgbuf);

Attachment: pgpCjlbX3JYoG.pgp
Description: PGP signature