Hi all, attached is a patch which tries to eliminate some duplicated code from libimap: - replace the custom implementation for base64 encoding and decoding by the respective glib functions - use libnetclient to calculate the CRAM-MD5 authentication message. I verified the changed implementation against a local dovecot instance, for both "cram-md5" and "plain" authentication. Opinions? Cheers, Albrecht. --- Patch details: - Makefile.am: ensure libnetclient is built before libbalsa, so the imap test code can link properly - libbalsa/imap/Makefile.am: add libnetclient to include path, link test app against it - imap/auth-cram.c: use net_client_cram_calc(), and wipe sensitive data before free - libbalsa/imap/imap-auth.c: g_base64_encode() instead of custom function - libbalsa/imap/util.[hc]: remove custom base64 encode and decode stuff
Attachment:
libimap-cleanups.diff
Description: Text Data
Attachment:
pgpcJgz90WtpT.pgp
Description: PGP signature