Re: BUG - threading view and selecting



On Jan 20, 2009, at  5:49 AM, Mario Mikocevic wrote:
Hello,

choose any mailbox with more than one message in one thread,
choose any threading display method in View menu (Simple or JWZ),
choose Colapse All from the same menu (if it isn't already).

Now expand that particular thread with clicking on triangles and
select any message other than first one in thread.

Click on *first* triangle in thread.

From this moment on, you can't select *any* other message in that
mailbox. Clicking on first triangle (expanding thread part) makes
selecting work again.

Hmmm, yes, that's broken, isn't it? Svn has a proposed fix--please check it out!

The bug is in a piece of code that manages what happens when you hide the currently previewed message by collapsing its thread. The native behavior of a GtkTreeView is that the message becomes unselected, and in the simplest implementation of a mailbox index, the preview would be cleared. It seemed more intuitive to keep the message in the preview, and to reselect it if the user re-expands the thread as far as that message, but achieving that complicates the code a little.

The proposed fix also changes one piece of behavior in that context: if you have multiple messages selected at the time that you hide the current message, they all become unselected. Having one message in the preview, and a different message highlighted in the message list, seemed likely to be confusing. In the current code, all the others become unselected when the thread is expanded again, so the difference is only in the timing (at collapse time, in the fix, as opposed to expand time, in the current code).

Comments or suggestions?

Peter

Attachment: pgpoLDFjQVnPK.pgp
Description: PGP signature



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]