Re: [PATCH] two small balsa 2.0 fixes

On Sun, 22 Feb 2004 14:45:02, Albrecht Dreß wrote:
> Hi,
> below is a patch against the 2.0 cvs to fix two minor problems:
> (1) sometimes system error messages (e.g. through gpgme) which may contain  
> non UTF-8 encoded national characters are passed to libbalsa_information.  
> To avoid pango errors, first sanitise them (file src/information-dialog.c);
> (2) when gpg updates the trust database, it is not available for any crypto  
> operations. While the update is really fast (< 1 second) for small (~50  
> keys) key rings, users with huge key rings will see balsa stalling for as  
> long as several minutes. We now check if gpg is available before starting  
> any crypto operation and return a "try again later" error if not. Note that  
> this is not a bullet-proof check as the update process might be launched by  
> a background process (think of crond) in the few milliseconds between the  
> check and the real crypto operation (a classical race...), but it should  
> help in the vast majority of cases (files libbalsa/rfc3156.[hc], src/balsa- 
> message.c).
> Any comments?

Looks good, it's in. I just changed a couple of strings to make life easier  
for translators.

Something caught my eye though, is ~/.gnupg garanteed ? Can't you use a  
diferent directory ?

Carlos Morgado - chbm(a) - 
0x1FC57F0A FP:0A27 35D3 C448 3641 0573 6876 2A37 4BB2 1FC5 7F0A

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]