A patch finally

[Joachim Breitner <mail joachim-breitner de>]

Hi,

finally I managed to contribute something, although it's not much.

I am using gcc 3.1.1, and since the balsa Makefile activates -Werror, every warning that gcc-3.1 emits results in a error. I found 4 cases, three i could fix:

In libbalsa/filter-funcs.c and src/address-book.c there is a label at a end of a compound statement. Fixed by adding a ;
In src/balsa-app.c was a multi-line string. Fixed by putting on one line :-)
In src/filter-edit-callbacks.c, the use of "%x" spits a warning about the date beeing not 4 digits in all locales. Go figure. No Idea how to fix... (maybe make sure that gcc doesn't know that %x will be the format :-))

The patch is a unified cvs-patch against the latest source checked out with -r BALSA_2

I hope it helps.

Joachim

-- 
Joachim Breitner 
	mail@joachim-breitner.de | http://www.joachim-breitner.de | ICQ: 74513189
Zufälliger Spruch/Random Fortune:

By rule #1, 5.005 should always allow localization of lexical @_ . . .
             -- Larry Wall in <199710011704.KAA21395@wall.org>
? autom4te.cache
? test
? libmutt/po
? website/po
Index: libbalsa/filter-funcs.c
===================================================================
RCS file: /cvs/gnome/balsa/libbalsa/filter-funcs.c,v
retrieving revision 1.15.2.2
diff -u -r1.15.2.2 filter-funcs.c
--- libbalsa/filter-funcs.c	25 Feb 2002 19:07:23 -0000	1.15.2.2
+++ libbalsa/filter-funcs.c	16 Jul 2002 06:38:49 -0000
@@ -508,9 +508,10 @@
 	    buffer=g_string_append(buffer,"discard;\n");
 	    break;
 	    /* FIXME how to code other actions */
         case FILTER_NOTHING:
         case FILTER_PRINT:
         case FILTER_RUN:
+	    ;
 	}
 	buffer=g_string_append(buffer,"}\n");
     }
Index: src/address-book.c
===================================================================
RCS file: /cvs/gnome/balsa/src/address-book.c,v
retrieving revision 1.43.6.7
diff -u -r1.43.6.7 address-book.c
--- src/address-book.c	26 Jun 2002 08:26:48 -0000	1.43.6.7
+++ src/address-book.c	16 Jul 2002 06:38:52 -0000
@@ -793,6 +793,7 @@
             gtk_widget_destroy(GTK_WIDGET(ab));
         break;
     default: /* nothing */
+	;
     }
 }
 
Index: src/balsa-app.c
===================================================================
RCS file: /cvs/gnome/balsa/src/balsa-app.c,v
retrieving revision 1.215.2.20
diff -u -r1.215.2.20 balsa-app.c
--- src/balsa-app.c	13 Jun 2002 08:37:45 -0000	1.215.2.20
+++ src/balsa-app.c	16 Jul 2002 06:38:54 -0000
@@ -986,8 +986,7 @@
             if (nli->exclusive == exclusive)
                 break;
             else
-                g_warning("Unlocking an incorrectly nested mailbox_nodes 
-lock");
+                g_warning("Unlocking an incorrectly nested mailbox_nodes lock");
         }
     }