Re: [PATCH] PGP/GPG support for Balsa

[Laurent Cheylus <foxy free fr>]

En réponse à Steffen Klemer <masterofheap@gmx.net>:

> First of all: THANK YOU! Great work!

Great thanks.

> 1) When I use my signature (the one in .signature) it produces sth.
> like:
> 
> [start]
> - - - --  /"\
>   \ /  ASCII Ribbon Campaign    |      Try Not!
>    X  - NO HTML/RTF in e-mail   |    Do or Do Not.
>   / \ - NO MSWord docs in e-mail|There is no Try. -Yoda
> - - -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.0.6 (GNU/Linux)
> 
> iD8DBQE8uG6NmS6nrZLeh7URAlEaAJ95Uk4wcuzc5MXtnf1A6zjhPlTd7wCeIHuR
> yS5MGVOx8PSILDeDze0zB5g=
> =WWTf
> - - -----END PGP SIGNATURE-----
> [end]
> 
> Your code as well as seahorse and gpgp (two gpg-frontends) result in an
> incorrect sign message.

No, my code is correct. If a PGP/GPG signed message has some lines that begins 
with "-", all these lines are "dash escaped" ("-" are replaced by "- -"). See 
RFC 2440 for details.  

> and as a third note:
> If you don't type in your passphrase (e.g. just clicking 3 times ok or
> clicking cancel) balsa will crash with
> 
> GLib-CRITICAL **: file gstrfuncs.c: line 1194 (g_strcasecmp): assertion
> `s1 != NULL' failed.
> gpg.c:536: GpgmeError Canceled

Yes, my code does not support now a correct mechanism for exception handling. 
This bug will be corrected in my future release.

I am going for the south of France :-) for my holidays for 5 days. I will back 
for reply to messages Sunday.

A++, Laurent.

--
Laurent Cheylus <foxy@free.fr> OpenPGP ID 0x5B766EC2