Re: Patch: Handle distribution lists on alias expansion

[Toralf Lund <toralf kscanners com>]

On 2001.09.21 12:51 Toralf Lund wrote:
> > On 2001.09.21 09:49 Toralf Lund wrote:
> > > On 2001.09.20 16:40 Brian Stafford wrote:
> > > > On Thu, 20 September 15:36 Toralf Lund wrote:
> > > > 
> > > > > 1. Insert full name according to RFC-822 for each address when a
> > > > > distribution list is found - refer to notes on code.
> > > > 
> > > > RFC 822 is obsolete.  The correct reference is RFC 2822.
> > > I see.
> > > 
> > > I actually read some of the RFC now ;-) Based on the information
> there,
> > I
> > > think we can do [see attached patch] [ ... ]
> > >
> > > 
> > > Also, I've now introduced an inconsistency in the formatting between
> > > addresses found by alias expansion and the ones selected in the
> address
> > > book, obviously the address list code ought to be shared between the
> > two
> > > lookup methods (it's not my fault that it isn't, of course...)
> > I fixed that, too; another patch is attached (it replaces the other
> two.)
> > Question: Why didn't expand_alias_find_match() call
> > libbalsa_address_to_gchar() all along?
> I just discovered a problem with my code: It seems like is_mailing_list()
> sometimes returns the wrong result. I really don't know how the test
> ought
> to be written to cover all cases. You might use
> LibBalsaAddressBook::dist_list_mode, of course, but that requires the
> address book to be found (is there a way to lookup the address book based
> on an address), and it's not really what we want for LDIF/LDAP. In fact,
> the "dist list" parameter is fairly meaningless for those as person (or
> organization) entries and distribution lists are completely distinct for
> those types. What we really want is probably to keep more of the
> structure
> from the address book data.
Looks like modifying the code so that dist_list_mode is stored for every
address would be fairly simple. I may submit a patch that will do just that
later, but I think I'll await further comments on everything first. Now
over to a completely different project...

- Toralf