PATCH: cleanup + vim sets remove
- From: Ali Akcaagac <ali akcaagac stud fh-wilhelmshaven de>
- To: balsa-list gnome org
- Subject: PATCH: cleanup + vim sets remove
- Date: Sun, 14 Oct 2001 21:30:49 +0200
patch 1:
cleanup of src/sendmsg-window.c we check that there is a
correct FROM: or TO: information in the textfields. something
i dont understand is, why its so cluttered. this one simplifies
and makes code reading easier..
patch 2:
this removes every vim: blahsettings headertags out of the balsa
code, reasons are comming up now.
a) it completely crappyfies reading the existing balsa code its
totally impossible reading the code cleanly
b) when doing some code on balsa, you get shit out that really
dont fit balsa's codingstyle. dunno who implemented them but
they are really sad. i am able following balsa style by following
the stuff in the code and my own made ~/.vimrc file theres no need
to overrun and annoy programming.
--
Name....: Ali Akcaagac
Status..: Student Of Computer & Economic Science
E-Mail..: mailto:ali.akcaagac@stud.fh-wilhelmshaven.de
WWW.....: http://www.fh-wilhelmshaven.de/~akcaagaa
diff -ruN balsa-cvs/src/sendmsg-window.c balsa/src/sendmsg-window.c
--- balsa-cvs/src/sendmsg-window.c Sun Oct 14 21:12:32 2001
+++ balsa/src/sendmsg-window.c Sun Oct 14 21:26:01 2001
@@ -2272,45 +2272,43 @@
static gboolean
is_ready_to_send(BalsaSendmsg * bsmsg)
{
- GList* list = NULL;
- GList* l;
- gchar *tmp;
+ GList *list = NULL;
+ gchar *tmp = NULL;
size_t len;
list = g_list_append(list, gtk_entry_get_text(GTK_ENTRY(bsmsg->to[1])));
- l = list =
- g_list_append(list, gtk_entry_get_text(GTK_ENTRY(bsmsg->from[1])));
+ list = g_list_append(list, gtk_entry_get_text(GTK_ENTRY(bsmsg->from[1])));
while (list) {
- tmp = (gchar*) list->data;
- len = strlen(tmp);
-
- if (len < 1) { /* empty */
- g_list_free(l);
- return FALSE;
- }
-
-
- if (tmp[len - 1] == '@') { /* this shouldn't happen */
- g_list_free(l);
- return FALSE;
- }
-
- if (len < 4) {
- if (strchr(tmp, '@')) {
- /* you won't have an @ in an address less than 4
- characters */
- g_list_free(l);
- return FALSE;
- }
-
- /* assume they are mailing it to someone in their local domain */
- }
+ tmp = (gchar*) list->data;
+ len = strlen(tmp);
- list = g_list_next(list);
+ if (len < 1) {
+ /* empty */
+ g_list_free(list);
+ return FALSE;
+ }
+
+ if (tmp[len - 1] == '@') {
+ /* this shouldn't happen */
+ g_list_free(list);
+ return FALSE;
+ }
+
+ if (len < 4) {
+ if (strchr(tmp, '@')) {
+ /* you won't have an @ in an address less than 4 characters */
+ g_list_free(list);
+ return FALSE;
+ }
+
+ /* assume they are mailing it to someone in their local domain */
+ }
+
+ list = g_list_next(list);
}
-
- g_list_free(l);
+
+ g_list_free(list);
return TRUE;
}
diff -ruN balsa-cvs/libbalsa/mime.c balsa/libbalsa/mime.c
--- balsa-cvs/libbalsa/mime.c Sun Oct 14 21:12:34 2001
+++ balsa/libbalsa/mime.c Sun Oct 14 21:13:09 2001
@@ -1,5 +1,4 @@
/* -*-mode:c; c-style:k&r; c-basic-offset:4; -*- */
-/* vim:set ts=4 sw=4 ai et: */
/* Balsa E-Mail Client
*
* Copyright (C) 1997-2000 Stuart Parmenter and others,
diff -ruN balsa-cvs/libbalsa/misc.c balsa/libbalsa/misc.c
--- balsa-cvs/libbalsa/misc.c Sun Oct 14 21:12:34 2001
+++ balsa/libbalsa/misc.c Sun Oct 14 21:13:12 2001
@@ -1,5 +1,4 @@
/* -*-mode:c; c-style:k&r; c-basic-offset:4; -*- */
-/* vim:set ts=4 sw=4 ai et: */
/* Balsa E-Mail Client
*
* Copyright (C) 1997-2001 Stuart Parmenter and others,
diff -ruN balsa-cvs/libbalsa/misc.h balsa/libbalsa/misc.h
--- balsa-cvs/libbalsa/misc.h Sun Oct 14 21:12:34 2001
+++ balsa/libbalsa/misc.h Sun Oct 14 21:13:15 2001
@@ -1,5 +1,4 @@
/* -*-mode:c; c-style:k&r; c-basic-offset:4; -*- */
-/* vim:set ts=4 sw=4 ai et: */
/* Balsa E-Mail Client
*
* Copyright (C) 1997-2001 Stuart Parmenter and others,
diff -ruN balsa-cvs/libbalsa/send.c balsa/libbalsa/send.c
--- balsa-cvs/libbalsa/send.c Sun Oct 14 21:12:34 2001
+++ balsa/libbalsa/send.c Sun Oct 14 21:13:23 2001
@@ -1,5 +1,4 @@
/* -*-mode:c; c-style:k&r; c-basic-offset:4; -*- */
-/* vim:set ts=4 sw=4 ai et: */
/* Balsa E-Mail Client
*
* Copyright (C) 1997-2001 Stuart Parmenter and others,
diff -ruN balsa-cvs/src/balsa-app.c balsa/src/balsa-app.c
--- balsa-cvs/src/balsa-app.c Sun Oct 14 21:12:32 2001
+++ balsa/src/balsa-app.c Sun Oct 14 21:13:31 2001
@@ -1,5 +1,4 @@
/* -*-mode:c; c-style:k&r; c-basic-offset:4; -*- */
-/* vim:set ts=4 sw=4 ai et: */
/* Balsa E-Mail Client
* Copyright (C) 1997-2001 Stuart Parmenter and others,
* See the file AUTHORS for a list.
diff -ruN balsa-cvs/src/balsa-message.c balsa/src/balsa-message.c
--- balsa-cvs/src/balsa-message.c Sun Oct 14 21:12:32 2001
+++ balsa/src/balsa-message.c Sun Oct 14 21:13:34 2001
@@ -1,5 +1,4 @@
/* -*-mode:c; c-style:k&r; c-basic-offset:4; -*- */
-/* vim:set ts=4 sw=4 ai et: */
/* Balsa E-Mail Client
* Copyright (C) 1997-2001 Stuart Parmenter and others,
* See the file AUTHORS for a list.
diff -ruN balsa-cvs/src/main-window.c balsa/src/main-window.c
--- balsa-cvs/src/main-window.c Sun Oct 14 21:12:32 2001
+++ balsa/src/main-window.c Sun Oct 14 21:13:26 2001
@@ -1,5 +1,4 @@
/* -*-mode:c; c-style:k&r; c-basic-offset:4; -*- */
-/* vim:set ts=4 sw=4 ai et: */
/* Balsa E-Mail Client
* Copyright (C) 1997-2001 Stuart Parmenter and others,
* See the file AUTHORS for a list.
diff -ruN balsa-cvs/src/pref-manager.c balsa/src/pref-manager.c
--- balsa-cvs/src/pref-manager.c Sun Oct 14 21:12:32 2001
+++ balsa/src/pref-manager.c Sun Oct 14 21:13:37 2001
@@ -1,5 +1,4 @@
/* -*-mode:c; c-style:k&r; c-basic-offset:4; -*- */
-/* vim:set ts=4 sw=4 ai et: */
/* Balsa E-Mail Client
* Copyright (C) 1997-2001 Stuart Parmenter and others,
* See the file AUTHORS for a list.
diff -ruN balsa-cvs/src/save-restore.c balsa/src/save-restore.c
--- balsa-cvs/src/save-restore.c Sun Oct 14 21:12:32 2001
+++ balsa/src/save-restore.c Sun Oct 14 21:13:40 2001
@@ -1,5 +1,4 @@
/* -*-mode:c; c-style:k&r; c-basic-offset:4; -*- */
-/* vim:set ts=4 sw=4 ai et: */
/* Balsa E-Mail Client
* Copyright (C) 1997-2001 Stuart Parmenter and others,
* See the file AUTHORS for a list.
diff -ruN balsa-cvs/src/sendmsg-window.c balsa/src/sendmsg-window.c
--- balsa-cvs/src/sendmsg-window.c Sun Oct 14 21:12:32 2001
+++ balsa/src/sendmsg-window.c Sun Oct 14 21:13:28 2001
@@ -1,5 +1,4 @@
/* -*-mode:c; c-style:k&r; c-basic-offset:4; -*- */
-/* vim:set ts=4 sw=4 ai et: */
/* Balsa E-Mail Client
* Copyright (C) 1998-2001 Stuart Parmenter and others, see AUTHORS file.
*
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]