Re: Patches commited

[Albrecht Dreß <albrecht dress arcormail de>]

Hi Pawel!

Well, what can I say... thanks a lot for committing my two other patches!!
It's *really* a pleasure to see that I can do some useful things there :-))

Am 25.07.2001 10:57:31 schrieb(en) Pawel Salek:
> > > Subject:       Just another URL patch...
[snip]
> 
> Frankly, I still hesitate about it. I would be really happy if it could
> be possible to browse mails also on slower computers and I can sometimes
> see delays on my development PII 450MHz box (well, this is not the
> fastest around nowadays but I think balsa should be usable on simple
> web&mail only boxes. 

I also recognised delays, mostly when I start balsa and click on a mail (so
this is the first mail displayed in this session). BTW, my machine here is an
old PowerMac 7300 with a 166 MHz PPC 604e, which should be somewhat slower
than yours...

> I wonder if these delays are caused by balsa part or gtk, but I would be
> happy to get rid of them...

I have no idea if I have a profiler with a "normal" gnu system (do I have
one?) or not. So I tried a brute force approach and hacked a few lines into
balsa-message.c to see if the url detection stuff eats your (and my) cpu time.
I attach the patch to this mail (no, it's *not* coded nicely..., and of
course it should not go into the cvs ;-)). I include the results of some tests
below.

IMHO, in all cases the delay caused by scanning the mail does not explain the
slow response of balsa, especially when showing the first mail in a session. 
Just a thought: might this delay be caused by reading the mailbox file and
isolating the selected message? 

Thanks again,
Cheers,

	Albrecht.


O.K., here are the "measurements":

On the PPC 604e/166, running LinuxPPC 2000:

* click on a mail with tons of http url's (69.6 k):

part_info_init_mimetext:1491 @ 996081295,797997 (+996081295,797997 sec)
[compile URL regex]
part_info_init_mimetext:1499 @ 996081295,800140 (+0,002143 sec) [compile URL
regex done]
part_info_init_mimetext:1510 @ 996081296,074803 (+0,274663 sec)
[libbalsa_message_body_save_temporary() done]
part_info_init_mimetext:1521 @ 996081296,081015 (+0,006212 sec)
[libbalsa_readfile() done]
part_info_init_mimetext:1547 @ 996081296,089253 (+0,008238 sec)
[libbalsa_wrap_string() done]
part_info_init_mimetext:1586 @ 996081296,106236 (+0,016983 sec) [start with
gtk_text_insert_with_url()]
part_info_init_mimetext:1605 @ 996081296,496028 (+0,389792 sec) [done with
gtk_text_insert_with_url()]
part_info_init_mimetext:1635 @ 996081296,504299 (+0,008271 sec) [exit
part_info_init_mimetext()]
mail_text_draw:1348 @ 996081297,106985 (+0,602686 sec) [enter draw]
mail_text_draw:1399 @ 996081297,212007 (+0,105022 sec) [draw finished]

===> ~390 msecs to detect the url's, and ~105 msecs for the draw event which
builds the hotarea list

* your mail (887 bytes)

part_info_init_mimetext:1491 @ 996081396,226086 (+99,014079 sec) [compile URL
regex]
part_info_init_mimetext:1499 @ 996081396,232673 (+0,006587 sec) [compile URL
regex done]
part_info_init_mimetext:1510 @ 996081396,237134 (+0,004461 sec)
[libbalsa_message_body_save_temporary() done]
part_info_init_mimetext:1521 @ 996081396,240344 (+0,003210 sec)
[libbalsa_readfile() done]
part_info_init_mimetext:1547 @ 996081396,240912 (+0,000568 sec)
[libbalsa_wrap_string() done]
part_info_init_mimetext:1586 @ 996081396,243185 (+0,002273 sec) [start with
gtk_text_insert_with_url()]
part_info_init_mimetext:1605 @ 996081396,245269 (+0,002084 sec) [done with
gtk_text_insert_with_url()]
part_info_init_mimetext:1635 @ 996081396,245879 (+0,000610 sec) [exit
part_info_init_mimetext()]
mail_text_draw:1348 @ 996081396,349656 (+0,103777 sec) [enter draw]
mail_text_draw:1399 @ 996081396,352404 (+0,002748 sec) [draw finished]

===> ~2 msecs to detect the url's, and ~3 msecs for the draw event

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
On a 730MHz PIII with RedHat 7.0:

* clicking on a mail just containing my bookmarks file (54.9 k):

part_info_init_mimetext:1491 @ 996054308,752663 (+996054308,752663 sec)
[compile URL regex]
part_info_init_mimetext:1499 @ 996054308,752925 (+0,000262 sec) [compile URL
regex done]
part_info_init_mimetext:1510 @ 996054308,780720 (+0,027795 sec)
[libbalsa_message_body_save_temporary() done]
part_info_init_mimetext:1521 @ 996054308,781540 (+0,000820 sec)
[libbalsa_readfile() done]
part_info_init_mimetext:1547 @ 996054308,782722 (+0,001182 sec)
[libbalsa_wrap_string() done]
part_info_init_mimetext:1586 @ 996054309,054473 (+0,271751 sec) [start with
gtk_text_insert_with_url()]
part_info_init_mimetext:1605 @ 996054309,085905 (+0,031432 sec) [done with
gtk_text_insert_with_url()]
part_info_init_mimetext:1635 @ 996054309,086851 (+0,000946 sec) [exit
part_info_init_mimetext()]
mail_text_draw:1348 @ 996054309,195964 (+0,109113 sec) [enter draw]
mail_text_draw:1399 @ 996054309,213690 (+0,017726 sec) [draw finished]

===> ~31 msecs to detect the url's, and ~18 msecs for the draw event

* clicking on a very short mail with just one url (322 bytes):

part_info_init_mimetext:1491 @ 996054312,469820 (+3,256130 sec) [compile URL
regex]
part_info_init_mimetext:1499 @ 996054312,469967 (+0,000147 sec) [compile URL
regex done]
part_info_init_mimetext:1510 @ 996054312,470486 (+0,000519 sec)
[libbalsa_message_body_save_temporary() done]
part_info_init_mimetext:1521 @ 996054312,470693 (+0,000207 sec)
[libbalsa_readfile() done]
part_info_init_mimetext:1547 @ 996054312,642235 (+0,171542 sec)
[libbalsa_wrap_string() done]
part_info_init_mimetext:1586 @ 996054312,642568 (+0,000333 sec) [start with
gtk_text_insert_with_url()]
part_info_init_mimetext:1605 @ 996054312,642826 (+0,000258 sec) [done with
gtk_text_insert_with_url()]
part_info_init_mimetext:1635 @ 996054312,643047 (+0,000221 sec) [exit
part_info_init_mimetext()]
mail_text_draw:1348 @ 996054312,774131 (+0,131084 sec) [enter draw]
mail_text_draw:1399 @ 996054312,774315 (+0,000184 sec) [draw finished]

===> ~.3 msecs to detect the url's, and ~.2 msecs for the draw event

-- 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    Albrecht Dreß  -  Monschauer Straße 22  -  D-53121 Bonn (Germany)
      Phone (+49) 228 6199571  -  E-Mail albrecht.dress@arcormail.de
_________________________________________________________________________

balsa-message-timestamp.gz