Re: icons rework and code cleanup

[christophe barbe <christophe barbe ml online fr>]

I've tested your patch and agree with you that it's cleaner.
Just two comments:
. I would be better if your patches where compatible with "patch -p1" which
is I believe the common way to do it.
. Could you avoid .tar.bz2 file when possible. For your last one, the
equivalent patch is only 37kbytes.

Oops I just detect that the identity icon in the compose window show
sometimes stange background colors (when you click on it).
Do you see the same thing ?

Christophe

Le 2001.08.16 22:33:40 +0200, Ali Akcaagac a écrit :
> hi,
> 
> i think you gonna like this. i reworked most of the icons
> and cleaned the src/balsa-icons.[ch] up completely. this
> means.
> 
> many xpm icons contained old trashed data or obsolete
> colors or were simply old data's, these got cleaned up
> 
> a) i loaded them into gimp, made sure they are either
>    24x24 or 16x16 (besides 2 exceptions) and that only
>    the colors get saved that are used. the icons are
>    still shaped and colored as before, no pixel lost.
> 
> b) i replaced some icons with 'evolution' icons, these
>    look terribly cool now, but hey, i didn't replaced all
>    gnome internal icons, only these that were really
>    awfull. i still wanted to keep the GNOME feeling and
>    consistency.
> 
> c) icons replaced completely.
> 
>    - the attachment icon when shown in the clist got replaced
>      and look stylish now. (same as in evolution)
>    - the flagged sign never fitted correctly into balsa, this
>      got replaced completely. (same as in evolution)
>    - the mark all messages icon got reworked and now it fits
>      nicely into a 24x24 xpm file and looks cool.
>    - now some hammerchange, i replaced the agressive and really
>      ugly identify icons. i simply replaced them with these in
>      yes guess what. they look terribly cool now.
> 
> d) obsolete icons, never used anymore got deleted in the
>    src/pixmaps directory
> 
> e) src/balsa-icons.[ch], the code got indented as recommendet by
>    pawel, redundant stuff got deleted, icons got ordered in the
>    code.
> 
> please apply below patch to recent CVS and completely replace the
> src/pixmaps directory with the attached tarball (not overwrite).
> 
> please comment how you like them. would be cool to commit them
> to the cvs for permanent usage, not only for the icons, also for
> the cleaned up code.
> 
> thanks.
> 
> -- 
> Name....: Ali Akcaagac
> Status..: Student Of Computer & Economic Science
> E-Mail..: mailto:ali.akcaagac@stud.fh-wilhelmshaven.de
> WWW.....: http://www.fh-wilhelmshaven.de/~akcaagaa
> 
-- 
Christophe Barbé <christophe.barbe@online.fr>
GnuPG FingerPrint: E0F6 FADF 2A5C F072 6AF8  F67A 8F45 2F1E D72C B41E