Re: mblist fixup

[Peter Bloomfield <PeterBloomfield MindSpring com>]

On 2001.08.15 07:24 Pawel Salek wrote:
> 
> On 2001-08-15 12:51 Ali Akcaagac wrote:
> > hello,
> > 
> > whenever i read src/balsa-mblist.c i come over to this line that
> > you read in the attached fix. i wonder if this shouldn't be fixed
> > as i recommend it. i am not 100% sure about this but the previous
> 
> You are right, the test is redundant but the line in question (IMO)
> should be:
> 
> icon = BALSA_ICON_TRAY_FULL;
> 
> That's all. /pawel

Pawel:

That looks right. While you're fixing redundancies, you could change 
the code a little further down:

                if (mailbox == balsa_app.inbox)
                    icon = BALSA_ICON_INBOX;
                else if (mailbox == balsa_app.outbox)
                    icon = BALSA_ICON_OUTBOX;
                else if (mailbox == balsa_app.trash)
                    icon = BALSA_ICON_TRASH;
                else
                    icon = BALSA_ICON_TRAY_EMPTY;

might as well be

                if (mailbox == balsa_app.inbox)
                    icon = BALSA_ICON_INBOX;
                else
                    icon = BALSA_ICON_TRAY_EMPTY;

Peter