Re: AUTH extension

[Brian Stafford <brian stafford uklinux net>]

Hi Pawel,

I've found a typo in the CRAM-MD5 code which prevents successful authentication
with this SASL mechansim.  Basically, the hmac calculation was correct but it
wasn't converted to hexadecimal properly!  The following patch fixes it.

Index: crammd5/client-crammd5.c
===================================================================
RCS file: /usr/local/cvsroot/libesmtp/crammd5/client-crammd5.c,v
retrieving revision 1.2
diff -u -r1.2 client-crammd5.c
--- crammd5/client-crammd5.c    2001/08/01 21:00:46     1.2
+++ crammd5/client-crammd5.c    2001/08/13 13:18:43
@@ -126,7 +126,7 @@
       p = strchr (response, '\0');
       for (i = 0; i < sizeof digest; i++)
         {
-          *p = hex[(digest[i] >> 4) & 0x0F];
+          *p++ = hex[(digest[i] >> 4) & 0x0F];
           *p++ = hex[digest[i] & 0x0F];
         }
       /* Note no \0 termination */


Regards
Brian