Hi!
I wanted to know what else needs to be changed in https://bugzilla.gnome.org/show_bug.cgi?id=711512 for it to be accepted?
I have commited it - see the bug report for details on indentation issues.
Also I was facing problems in handling the keypress events for fixing bug https://bugzilla.gnome.org/show_bug.cgi?id=708792 since the "Alt +E" keypress event for changing focus from Terminal to Editor does not seem to work. This is what I have added to the GtkActionEntry of file plugins/terminal/terminal.c { "ActionCommandToTerminal-ALTE" , NULL, N_("Alt-E"), "<Alt>E", NULL, G_CALLBACK (on_terminal_shift) },
I am pretty sure the "Alt-E" is already caught (and consumed) by the terminal window so you will never see it later. You will have to you use "<Ctrl><Alt>E" or something like that. The reason is that to use a terminal window, most of the key events are usually need. Image you want to abort a program with Ctrl-C. Btw: _N("Alt-E") is wrong - the string should explain the action so it must be something like "Switch to terminal" or the like. Regards, Johannes
Attachment:
signature.asc
Description: This is a digitally signed message part