[easytag] Fix checking whether ID3v1 and ID3v2 are enabled



commit 692749a8e2cec9377345b03139abda8c032adf05
Author: David King <amigadave amigadave com>
Date:   Mon Sep 8 11:42:54 2014 +0100

    Fix checking whether ID3v1 and ID3v2 are enabled
    
    As reported by Steven Ulrick on the mailing list, saving files with ID3
    tags and then reloading the directory causes the files to be shown as
    modified, even though they are not.
    
    https://mail.gnome.org/archives/easytag-list/2014-September/msg00014.html

 src/tags/id3v24_tag.c |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)
---
diff --git a/src/tags/id3v24_tag.c b/src/tags/id3v24_tag.c
index a7b0fc6..064a821 100644
--- a/src/tags/id3v24_tag.c
+++ b/src/tags/id3v24_tag.c
@@ -134,7 +134,7 @@ gboolean Id3tag_Read_File_Tag (const gchar *filename, File_Tag *FileTag)
     if ((tagsize = id3_tag_query((id3_byte_t const *)string1, ID3_TAG_QUERYSIZE)) <= ID3_TAG_QUERYSIZE)
     {
         /* ID3v2 tag not found! */
-        update = !g_settings_get_boolean (MainSettings, "id3v2-enabled");
+        update = g_settings_get_boolean (MainSettings, "id3v2-enabled");
     }else
     {
         /* ID3v2 tag found */
@@ -180,13 +180,17 @@ gboolean Id3tag_Read_File_Tag (const gchar *filename, File_Tag *FileTag)
        )
     {
         /* ID3v1 tag found! */
-        if (g_settings_get_boolean (MainSettings, "id3v1-enabled"))
+        if (!g_settings_get_boolean (MainSettings, "id3v1-enabled"))
+        {
             update = 1;
+        }
     }else
     {
         /* ID3v1 tag not found! */
-        if (!g_settings_get_boolean (MainSettings, "id3v1-enabled"))
+        if (g_settings_get_boolean (MainSettings, "id3v1-enabled"))
+        {
             update = 1;
+        }
     }
 
     g_free(string1);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]