Re: [Tracker] *-private.h files

["Jaap A. Haitsma" <jaap haitsma org>]

On Jan 6, 2008 5:04 AM, Saleem Abdulrasool <compnerd gentoo org> wrote:
> On Sat, 05 Jan 2008, Jamie McCracken wrote:
>
> > > 1) Now all the static function declarations are in the beginning of
> > > the c file, but ofcourse if you reorder the code a bit this is not
> > > necessary (I always use this because it saves time and typing if you
> > > decide to change the arguments in the function. I see that also in
> > > other parts of the tracker code  base)
> > > If you want I can reorder the functions so that the prototypes are not
> > > necessary anymore
> >
> > I usually avoid prototypes but other contributions included them and it
> > would not seem right to force them to change. Probably best to leave as
> > is in case it upsets one of the contributors
>
> Since you guys prefer otherwise, I will reorder the code soon and remove
> the prototypes.  I just tend to prefer the prototypes as they do help
> with catching errors.
Saleem,

One other thing I noticed concerning coding style. In tracker applet
you assign all translatable strings to global variables. I've haven't
seen that in any other GNOME projects. I also think (correct me if I'm
wrong) that it's not that handy to do it like this for translators and
programmers, because you have too look at where the variable get
assigned and where it''s being used. If you just put the string where
you use it in the code you just have to look at one place

Jaap