Re: bonding options rework experiment (dcbw/bondopts)



Hi Dan,

On Thu, 2013-11-14 at 19:57 -0600, Dan Williams wrote:
I've pushed my experiments here to dcbw/bondopts, enough that it
compiles and passes 'make check' in libnm-util, although we certainly
don't have enough testcase coverage of bonding to make sure it works.

My main attempts were to use the normal GObject property ParamSpecs for
min/max validation and all defaults, and to reduce some of the legacy
property complexity by just exposing all the properties in the old
'options' property.

Thoughts?


I like it. I was looking at it all and changed the parts, where I think
it should be different.

Patch attached.

Thomas



Attachment: 0001-fixup-bond-add-proper-properties-to-NMSettingBond-de.patch
Description: Text Data

Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]