Re: [MM] [PATCH] iface-modem: fix modem state consolidation upon bearer disconnection



On 02/20/2013 07:22 AM, Ben Chan wrote:
Patch "iface-modem: fix invalid modem state consolidation" (commit
69aff6183a9e6532b4074c89831d6dcfa81ddcce) incorrectly consolidates the
modem state upon the disconnection of a bearer. The modem state remains
'connected' after the last bearer is disconnected. This patch fixes
that.

Pushed, thanks for finding this.

---
 src/mm-iface-modem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mm-iface-modem.c b/src/mm-iface-modem.c
index 63ef6fc..f02b0bd 100644
--- a/src/mm-iface-modem.c
+++ b/src/mm-iface-modem.c
@@ -270,7 +270,7 @@ bearer_status_changed (MMBearer *bearer,
             new_state = MM_MODEM_STATE_DISCONNECTING;
             break;
         case MM_BEARER_STATUS_DISCONNECTED:
-            new_state = get_current_consolidated_state (self, state);
+            new_state = get_current_consolidated_state (self, MM_MODEM_STATE_UNKNOWN);
             break;
         }
 



-- 
Aleksander


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]